From 692633845a16008e78e964458edc31a00d7005c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Henry?= Date: Tue, 7 Jan 2025 14:38:39 +0100 Subject: [PATCH 1/2] TESTING: Improve AXFRDDNS integration tests (#3317) --- integrationTest/integration_test.go | 18 ++++++++++++------ integrationTest/profiles.json | 4 ++-- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/integrationTest/integration_test.go b/integrationTest/integration_test.go index 1e3f1be64..ae48a3cb8 100644 --- a/integrationTest/integration_test.go +++ b/integrationTest/integration_test.go @@ -248,14 +248,20 @@ func makeChanges(t *testing.T, prv providers.DNSServiceProvider, dc *models.Doma //} dom.Records = append(dom.Records, &rc) } - //if *providerToRun == "AXFRDDNS" { - // Bind will refuse a DDNS update when the resulting zone - // contains a NS record without an associated address - // records (A or AAAA) - //dom.Records = append(dom.Records, a("ns."+domainName+".", "9.8.7.6")) - //} dom.Unmanaged = tst.Unmanaged dom.UnmanagedUnsafe = tst.UnmanagedUnsafe + // Bind will refuse a DDNS update when the resulting zone + // contains a NS record without an associated address + // records (A or AAAA). In order to run the integration tests + // against bind, the initial zone contains the following records: + // - `@ NS dummy-ns.example.com` + // - `dummy-ns A 9.8.7.6` + // We 'hardcode' an ignore rule for the `A` record. + dom.Unmanaged = append(dom.Unmanaged, &models.UnmanagedConfig{ + LabelPattern: "dummy-ns", + RTypePattern: "A", + TargetPattern: "", + }) models.PostProcessRecords(dom.Records) dom2, _ := dom.Copy() diff --git a/integrationTest/profiles.json b/integrationTest/profiles.json index 555dff041..860e62e84 100644 --- a/integrationTest/profiles.json +++ b/integrationTest/profiles.json @@ -22,7 +22,7 @@ "master": "$AXFRDDNS_MASTER", "nameservers": "ns.example.com", "transfer-key": "$AXFRDDNS_TRANSFER_KEY", - "transfer-mode": "AXFRDDNS_TRANSFER_MODE", + "transfer-mode": "$AXFRDDNS_TRANSFER_MODE", "update-key": "$AXFRDDNS_UPDATE_KEY", "update-mode": "$AXFRDDNS_UPDATE_MODE" }, @@ -32,7 +32,7 @@ "master": "$AXFRDDNS_DNSSEC_MASTER", "nameservers": "ns.example.com", "transfer-key": "$AXFRDDNS_DNSSEC_TRANSFER_KEY", - "transfer-mode": "AXFRDDNS_DNSSEC_TRANSFER_MODE", + "transfer-mode": "$AXFRDDNS_DNSSEC_TRANSFER_MODE", "update-key": "$AXFRDDNS_DNSSEC_UPDATE_KEY", "update-mode": "$AXFRDDNS_DNSSEC_UPDATE_MODE" }, From cc366d4306a2c1d5cf961b25b96a97517107005f Mon Sep 17 00:00:00 2001 From: "Berk D. Demir" <11135+bdd@users.noreply.github.com> Date: Tue, 7 Jan 2025 05:50:46 -0800 Subject: [PATCH 2/2] ROUTE53: Add HTTPS, SSHFP, SVCB, and TLSA record types (#3316) Co-authored-by: Tom Limoncelli --- documentation/provider/index.md | 2 +- providers/route53/route53Provider.go | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/documentation/provider/index.md b/documentation/provider/index.md index adba7a8a2..f27b850cf 100644 --- a/documentation/provider/index.md +++ b/documentation/provider/index.md @@ -61,7 +61,7 @@ If a feature is definitively not supported for whatever reason, we would also li | [`PORKBUN`](porkbun.md) | ❌ | ✅ | ✅ | ❌ | ✅ | ✅ | ❌ | ❔ | ❌ | ❌ | ❌ | ❌ | ✅ | ❌ | ❔ | ✅ | ❌ | ❔ | ❔ | ❔ | ❌ | ❌ | ✅ | | [`POWERDNS`](powerdns.md) | ❌ | ✅ | ❌ | ❌ | ✅ | ✅ | ✅ | ❔ | ❔ | ✅ | ✅ | ❔ | ✅ | ✅ | ❔ | ✅ | ✅ | ✅ | ❔ | ❔ | ✅ | ✅ | ✅ | | [`REALTIMEREGISTER`](realtimeregister.md) | ❌ | ✅ | ✅ | ❌ | ✅ | ✅ | ✅ | ❔ | ✅ | ✅ | ❌ | ❌ | ✅ | ✅ | ❔ | ✅ | ❌ | ❌ | ❔ | ❔ | ❌ | ✅ | ✅ | -| [`ROUTE53`](route53.md) | ✅ | ✅ | ✅ | ✅ | ❌ | ✅ | ❔ | ❔ | ❌ | ❔ | ✅ | ❔ | ✅ | ❔ | ❔ | ❔ | ❔ | ❔ | ❔ | ❔ | ✅ | ✅ | ✅ | +| [`ROUTE53`](route53.md) | ✅ | ✅ | ✅ | ✅ | ❌ | ✅ | ❔ | ✅ | ❌ | ❔ | ✅ | ❔ | ✅ | ✅ | ✅ | ✅ | ❔ | ❔ | ❔ | ❔ | ✅ | ✅ | ✅ | | [`RWTH`](rwth.md) | ❌ | ✅ | ❌ | ❌ | ❌ | ✅ | ❔ | ❔ | ❌ | ❌ | ✅ | ❔ | ✅ | ✅ | ❔ | ❌ | ❔ | ❔ | ❔ | ❔ | ❌ | ❌ | ✅ | | [`SAKURACLOUD`](sakuracloud.md) | ❌ | ✅ | ❌ | ❌ | ✅ | ✅ | ❌ | ✅ | ❌ | ❌ | ✅ | ❌ | ✅ | ❌ | ✅ | ❌ | ❌ | ❌ | ❌ | ❌ | ❌ | ✅ | ✅ | | [`SOFTLAYER`](softlayer.md) | ❌ | ✅ | ❌ | ❌ | ❔ | ❔ | ❔ | ❔ | ❌ | ❔ | ❔ | ❔ | ✅ | ❔ | ❔ | ❔ | ❔ | ❔ | ❔ | ❔ | ❔ | ❌ | ❔ | diff --git a/providers/route53/route53Provider.go b/providers/route53/route53Provider.go index 05d3fdcb1..daa17623d 100644 --- a/providers/route53/route53Provider.go +++ b/providers/route53/route53Provider.go @@ -81,10 +81,14 @@ var features = providers.DocumentationNotes{ providers.CanConcur: providers.Can(), providers.CanUseAlias: providers.Cannot("R53 does not provide a generic ALIAS functionality. Use R53_ALIAS instead."), providers.CanUseCAA: providers.Can(), + providers.CanUseHTTPS: providers.Can(), providers.CanUseLOC: providers.Cannot(), providers.CanUsePTR: providers.Can(), providers.CanUseRoute53Alias: providers.Can(), providers.CanUseSRV: providers.Can(), + providers.CanUseSSHFP: providers.Can(), + providers.CanUseSVCB: providers.Can(), + providers.CanUseTLSA: providers.Can(), providers.DocCreateDomains: providers.Can(), providers.DocDualHost: providers.Can(), providers.DocOfficiallySupported: providers.Can(),