StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-12-12 15:59:39 +08:00
Code Issues Projects Releases Packages Wiki Activity

VERCEL: fix HTTPS/SRV record

Browse source
This commit is contained in:
SukkaW 2025-12-04 20:19:30 +08:00
parent c11a523982
commit 3a24185faf
2 changed files with 25 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
providers/vercel/api.go
View file

@ -89,12 +89,13 @@ func (c *vercelProvider) ListDNSRecords(ctx context.Context, domain string) ([]D
type httpsRecord struct { type httpsRecord struct {
Priority int64 `json:"priority"` Priority int64 `json:"priority"`
Target string `json:"target"` Target string `json:"target"`
Params string `json:"params,omitempty"` Params string `json:"params"`
} }
// createDNSRecordRequest embeds the official SDK request but adds HTTPS support // createDNSRecordRequest embeds the official SDK request but adds HTTPS support
type createDNSRecordRequest struct { type createDNSRecordRequest struct {
vercelClient.CreateDNSRecordRequest vercelClient.CreateDNSRecordRequest
Value *string `json:"value,omitempty"`
HTTPS *httpsRecord `json:"https,omitempty"` HTTPS *httpsRecord `json:"https,omitempty"`
} }

28
providers/vercel/vercelProvider.go
View file

@ -317,7 +317,7 @@ func toVercelCreateRequest(domain string, rc *models.RecordConfig) (createDNSRec
} }
req.Name = name req.Name = name
req.Type = rc.Type req.Type = rc.Type
req.Value = rc.GetTargetField() req.Value = ptrString(rc.GetTargetField())
req.TTL = int64(rc.TTL) req.TTL = int64(rc.TTL)
req.Comment = "" req.Comment = ""
@ -331,17 +331,24 @@ func toVercelCreateRequest(domain string, rc *models.RecordConfig) (createDNSRec
Port: int64(rc.SrvPort), Port: int64(rc.SrvPort),
Target: rc.GetTargetField(), Target: rc.GetTargetField(),
} }
req.Value = "" // SRV uses the SRV struct, not Value // When dealing with SRV records, we must not set the Value fields,
// otherwise the API throws an error:
// bad_request - Invalid request: should NOT have additional property `value`
req.Value = nil
case "TXT": case "TXT":
req.Value = rc.GetTargetTXTJoined() req.Value = ptrString(rc.GetTargetTXTJoined())
case "HTTPS": case "HTTPS":
req.HTTPS = &httpsRecord{ req.HTTPS = &httpsRecord{
Priority: int64(rc.SvcPriority), Priority: int64(rc.SvcPriority),
Target: rc.GetTargetField(), Target: rc.GetTargetField(),
Params: rc.SvcParams, Params: rc.SvcParams,
} }
// When dealing with HTTPS records, we must not set the Value fields,
// otherwise the API throws an error:
// bad_request - Invalid request: should NOT have additional property `value`.
req.Value = nil
case "CAA": case "CAA":
req.Value = fmt.Sprintf(`%v %s "%s"`, rc.CaaFlag, rc.CaaTag, rc.GetTargetField()) req.Value = ptrString(fmt.Sprintf(`%v %s "%s"`, rc.CaaFlag, rc.CaaTag, rc.GetTargetField()))
} }
return req, nil return req, nil
@ -373,7 +380,10 @@ func toVercelUpdateRequest(rc *models.RecordConfig) (updateDNSRecordRequest, err
Port: ptrInt64(int64(rc.SrvPort)), Port: ptrInt64(int64(rc.SrvPort)),
Target: &value, Target: &value,
} }
req.Value = nil // SRV uses the SRV struct, not Value // When dealing with SRV records, we must not set the Value fields,
// otherwise the API throws an error:
// bad_request - Invalid request: should NOT have additional property `value`
req.Value = nil
case "TXT": case "TXT":
txtValue := rc.GetTargetTXTJoined() txtValue := rc.GetTargetTXTJoined()
req.Value = &txtValue req.Value = &txtValue
@ -383,6 +393,10 @@ func toVercelUpdateRequest(rc *models.RecordConfig) (updateDNSRecordRequest, err
Target: rc.GetTargetField(), Target: rc.GetTargetField(),
Params: rc.SvcParams, Params: rc.SvcParams,
} }
// When dealing with HTTPS records, we must not set the Value fields,
// otherwise the API throws an error:
// bad_request - Invalid request: should NOT have additional property `value`.
req.Value = nil
case "CAA": case "CAA":
value := fmt.Sprintf(`%v %s "%s"`, rc.CaaFlag, rc.CaaTag, rc.GetTargetField()) value := fmt.Sprintf(`%v %s "%s"`, rc.CaaFlag, rc.CaaTag, rc.GetTargetField())
req.Value = &value req.Value = &value
@ -395,3 +409,7 @@ func toVercelUpdateRequest(rc *models.RecordConfig) (updateDNSRecordRequest, err
func ptrInt64(v int64) *int64 { func ptrInt64(v int64) *int64 {
return &v return &v
} }
func ptrString(v string) *string {
return &v
}