StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-09-20 14:56:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

TESTING: Mark 'IGNORE_TARGET b2285' as diff2-only (#2357)

Browse source 
Co-authored-by: Tom Limoncelli <tal@whatexit.org>
This commit is contained in:
Tom Limoncelli 2023-05-12 14:43:41 -04:00 committed by GitHub
parent 9e66c3760e
commit 3aac3d3b44
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
integrationTest/integration_test.go
View file

@ -1848,6 +1848,10 @@ func makeTests(t *testing.T) []*TestGroup {
),
),
// https://github.com/StackExchange/dnscontrol/issues/2285
// IGNORE_TARGET for CNAMEs wasn't working for AZURE_DNS.
// Interestingly enough, this has never worked with
// GANDI_V5/diff1. It works on all providers in diff2.
testgroup("IGNORE_TARGET b2285",
tc("Create some records",
cname("foo", "redact1.acm-validations.aws."),
@ -1856,7 +1860,7 @@ func makeTests(t *testing.T) []*TestGroup {
tc("Add a new record - ignoring test.foo.com.",
ignoreTarget("**.acm-validations.aws.", "CNAME"),
).ExpectNoChanges(),
),
).Diff2Only(),
// Narrative: Congrats! You're done! If you've made it this far
// you're very close to being able to submit your PR. Here's