StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-02-24 07:33:03 +08:00
Code Issues Projects Releases Packages Wiki Activity

PORKBUN: fix staticcheck warnings (#3159)

Browse source
This commit is contained in:
imlonghao 2024-10-15 21:33:51 +08:00 committed by GitHub
parent db91c71d10
commit 57f15c15cb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
providers/porkbun/api.go
View file

@ -152,14 +152,14 @@ func (c *porkbunProvider) getRecords(domain string) ([]domainRecord, error) {
return records, nil return records, nil
} }
func (c *porkbunProvider) createUrlForwardingRecord(domain string, rec requestParams) error { func (c *porkbunProvider) createURLForwardingRecord(domain string, rec requestParams) error {
if _, err := c.post("/domain/addUrlForward/"+domain, rec); err != nil { if _, err := c.post("/domain/addUrlForward/"+domain, rec); err != nil {
return fmt.Errorf("failed create url forwarding record (porkbun): %w", err) return fmt.Errorf("failed create url forwarding record (porkbun): %w", err)
} }
return nil return nil
} }
func (c *porkbunProvider) deleteUrlForwardingRecord(domain string, recordID string) error { func (c *porkbunProvider) deleteURLForwardingRecord(domain string, recordID string) error {
params := requestParams{} params := requestParams{}
if _, err := c.post(fmt.Sprintf("/domain/deleteUrlForward/%s/%s", domain, recordID), params); err != nil { if _, err := c.post(fmt.Sprintf("/domain/deleteUrlForward/%s/%s", domain, recordID), params); err != nil {
return fmt.Errorf("failed delete url forwarding record (porkbun): %w", err) return fmt.Errorf("failed delete url forwarding record (porkbun): %w", err)
@ -167,17 +167,17 @@ func (c *porkbunProvider) deleteUrlForwardingRecord(domain string, recordID stri
return nil return nil
} }
func (c *porkbunProvider) modifyUrlForwardingRecord(domain string, recordID string, rec requestParams) error { func (c *porkbunProvider) modifyURLForwardingRecord(domain string, recordID string, rec requestParams) error {
if err := c.deleteUrlForwardingRecord(domain, recordID); err != nil { if err := c.deleteURLForwardingRecord(domain, recordID); err != nil {
return err return err
} }
if err := c.createUrlForwardingRecord(domain, rec); err != nil { if err := c.createURLForwardingRecord(domain, rec); err != nil {
return err return err
} }
return nil return nil
} }
func (c *porkbunProvider) getUrlForwardingRecords(domain string) ([]domainRecord, error) { func (c *porkbunProvider) getURLForwardingRecords(domain string) ([]domainRecord, error) {
params := requestParams{} params := requestParams{}
var bodyString, err = c.post("/domain/getUrlForwarding/"+domain, params) var bodyString, err = c.post("/domain/getUrlForwarding/"+domain, params)
if err != nil { if err != nil {
@ -190,11 +190,7 @@ func (c *porkbunProvider) getUrlForwardingRecords(domain string) ([]domainRecord
return nil, fmt.Errorf("failed parsing url forwarding record list from porkbun: %w", err) return nil, fmt.Errorf("failed parsing url forwarding record list from porkbun: %w", err)
} }
var records []domainRecord return dr.Forwards, nil
for _, rec := range dr.Forwards {
records = append(records, rec)
}
return records, nil
} }
func (c *porkbunProvider) getNameservers(domain string) ([]string, error) { func (c *porkbunProvider) getNameservers(domain string) ([]string, error) {

8
providers/porkbun/porkbunProvider.go
View file

@ -146,7 +146,7 @@ func (c *porkbunProvider) GetZoneRecordsCorrections(dc *models.DomainConfig, exi
Msg: change.Msgs[0], Msg: change.Msgs[0],
F: func() error { F: func() error {
if change.New[0].Type == "PORKBUN_URLFWD" { if change.New[0].Type == "PORKBUN_URLFWD" {
return c.createUrlForwardingRecord(dc.Name, req) return c.createURLForwardingRecord(dc.Name, req)
} }
return c.createRecord(dc.Name, req) return c.createRecord(dc.Name, req)
}, },
@ -161,7 +161,7 @@ func (c *porkbunProvider) GetZoneRecordsCorrections(dc *models.DomainConfig, exi
Msg: fmt.Sprintf("%s, porkbun ID: %s", change.Msgs[0], id), Msg: fmt.Sprintf("%s, porkbun ID: %s", change.Msgs[0], id),
F: func() error { F: func() error {
if change.New[0].Type == "PORKBUN_URLFWD" { if change.New[0].Type == "PORKBUN_URLFWD" {
return c.modifyUrlForwardingRecord(dc.Name, id, req) return c.modifyURLForwardingRecord(dc.Name, id, req)
} }
return c.modifyRecord(dc.Name, id, req) return c.modifyRecord(dc.Name, id, req)
}, },
@ -172,7 +172,7 @@ func (c *porkbunProvider) GetZoneRecordsCorrections(dc *models.DomainConfig, exi
Msg: fmt.Sprintf("%s, porkbun ID: %s", change.Msgs[0], id), Msg: fmt.Sprintf("%s, porkbun ID: %s", change.Msgs[0], id),
F: func() error { F: func() error {
if change.Old[0].Type == "PORKBUN_URLFWD" { if change.Old[0].Type == "PORKBUN_URLFWD" {
return c.deleteUrlForwardingRecord(dc.Name, id) return c.deleteURLForwardingRecord(dc.Name, id)
} }
return c.deleteRecord(dc.Name, id) return c.deleteRecord(dc.Name, id)
}, },
@ -192,7 +192,7 @@ func (c *porkbunProvider) GetZoneRecords(domain string, meta map[string]string)
if err != nil { if err != nil {
return nil, err return nil, err
} }
forwards, err := c.getUrlForwardingRecords(domain) forwards, err := c.getURLForwardingRecords(domain)
if err != nil { if err != nil {
return nil, err return nil, err
} }