From 60324bc4f580e6c93c706177ace97e5ef9106381 Mon Sep 17 00:00:00 2001 From: Jan-Philipp Benecke Date: Thu, 9 Jun 2022 17:26:46 +0200 Subject: [PATCH] CLOUDFLAREAPI: FIX: Preventing segfault when Cloudflare API limit is reached (#1530) * Preventing segfault when Cloudflare API limit is reached Signed-off-by: Jan-Philipp Benecke * Add comment for future me Signed-off-by: Jan-Philipp Benecke --- providers/cloudflare/rest.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/providers/cloudflare/rest.go b/providers/cloudflare/rest.go index 3d7a98be1..7548ac51b 100644 --- a/providers/cloudflare/rest.go +++ b/providers/cloudflare/rest.go @@ -150,9 +150,13 @@ func (c *cloudflareProvider) createRec(rec *models.RecordConfig, domainID string } else if rec.Type == "DS" { cf.Data = cfDSData(rec) } - resp, err := c.cfClient.CreateDNSRecord(context.Background(), domainID, cf) - id = resp.Result.ID - return err + if resp, err := c.cfClient.CreateDNSRecord(context.Background(), domainID, cf); err != nil { + return err + } else { + // Updating id (from the outer scope) by side-effect, required for updating proxy mode + id = resp.Result.ID + return nil + } }, }} if rec.Metadata[metaProxy] != "off" {