StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-09-04 20:24:23 +08:00
Code Issues Projects Releases Packages Wiki Activity

Namecheap: switch throttling to only as needed. (#244)

Browse source 
* refactor namecheap to throttle only as needed

* note about srv records

* no it can't

* fmt
This commit is contained in:
Craig Peterson 2017-10-24 09:41:59 -04:00 • committed by GitHub
parent 1664b64a94
commit 60ed1a2e0b
2 changed files with 49 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/_includes/matrix.html
View file

@ -201,8 +201,8 @@
<td class="success">
<i class="fa fa-check text-success" aria-hidden="true"></i>
</td>
<td class="info" data-toggle="tooltip" data-container="body" data-placement="top" title="namecheap supports srv records, we just need someone to implement it and make sure the tests pass.">
<i class="fa fa-circle-o text-info" aria-hidden="true"></i>
<td class="danger" data-toggle="tooltip" data-container="body" data-placement="top" title="The namecheap web console allows you to make SRV records, but their api does not let you read or set them">
<i class="fa has-tooltip fa-times text-danger" aria-hidden="true"></i>
</td>
<td class="success">
<i class="fa fa-check text-success" aria-hidden="true"></i>

87
providers/namecheap/namecheap.go
View file

@ -3,6 +3,7 @@ package namecheap
import (
"encoding/json"
"fmt"
"log"
"sort"
"strings"
"time"
@ -30,14 +31,14 @@ var docNotes = providers.DocumentationNotes{
providers.DocDualHost: providers.Cannot("Doesn't allow control of apex NS records"),
providers.CanUseAlias: providers.Cannot(),
providers.CanUseCAA: providers.Cannot(),
providers.CanUseSRV: providers.Unimplemented("namecheap supports srv records, we just need someone to implement it and make sure the tests pass."),
providers.CanUseSRV: providers.Cannot("The namecheap web console allows you to make SRV records, but their api does not let you read or set them"),
providers.CanUsePTR: providers.Cannot(),
providers.CanUseTLSA: providers.Cannot(),
}
func init() {
providers.RegisterRegistrarType("NAMECHEAP", newReg, docNotes)
providers.RegisterDomainServiceProviderType("NAMECHEAP", newDsp, providers.CantUseNOPURGE)
providers.RegisterRegistrarType("NAMECHEAP", newReg)
providers.RegisterDomainServiceProviderType("NAMECHEAP", newDsp, providers.CantUseNOPURGE, docNotes)
providers.RegisterCustomRecordType("URL", "NAMECHEAP", "")
providers.RegisterCustomRecordType("URL301", "NAMECHEAP", "")
providers.RegisterCustomRecordType("FRAME", "NAMECHEAP", "")
@ -74,43 +75,43 @@ func splitDomain(domain string) (sld string, tld string) {
}
// namecheap has request limiting at unpublished limits
// this channel acts as a global rate limiter
// read from it before every request
// from support in SEP-2017:
// "The limits for the API calls will be 20/Min, 700/Hour and 8000/Day for one user.
// If you can limit the requests within these it should be fine."
var throttle = make(chan bool, 20)
func init() {
go func() {
for {
// add (up to) 20 requests every minute
for i := 0; i < 20; i++ {
select {
case throttle <- true:
default:
}
}
time.Sleep(time.Minute)
// this helper performs some api action, checks for rate limited response, and if so, enters a retry loop until it resolves
// if you are consistently hitting this, you may have success asking their support to increase your account's limits.
func doWithRetry(f func() error) {
// sleep 5 seconds at a time, up to 23 times (1 minute, 15 seconds)
const maxRetries = 23
const sleepTime = 5 * time.Second
var currentRetry int
for {
err := f()
if err == nil {
return
}
if strings.Contains(err.Error(), "Error 500000: Too many requests") {
currentRetry++
if currentRetry >= maxRetries {
return
}
log.Printf("Namecheap rate limit exceeded. Waiting %s to retry.", sleepTime)
time.Sleep(sleepTime)
} else {
return
}
}()
}
func doThrottle() {
select {
case <-throttle:
default:
fmt.Println("\nNamecheap request limit reached. Waiting for more requests to be available")
<-throttle
}
}
func (n *Namecheap) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Correction, error) {
dc.Punycode()
sld, tld := splitDomain(dc.Name)
doThrottle()
records, err := n.client.DomainsDNSGetHosts(sld, tld)
var records *nc.DomainDNSGetHostsResult
var err error
doWithRetry(func() error {
records, err = n.client.DomainsDNSGetHosts(sld, tld)
return err
})
if err != nil {
return nil, err
}
@ -208,8 +209,11 @@ func (n *Namecheap) generateRecords(dc *models.DomainConfig) error {
id++
}
sld, tld := splitDomain(dc.Name)
<-throttle
_, err := n.client.DomainDNSSetHosts(sld, tld, recs)
var err error
doWithRetry(func() error {
_, err = n.client.DomainDNSSetHosts(sld, tld, recs)
return err
})
return err
}
@ -221,8 +225,12 @@ func (n *Namecheap) GetNameservers(domainName string) ([]*models.Nameserver, err
}
func (n *Namecheap) GetRegistrarCorrections(dc *models.DomainConfig) ([]*models.Correction, error) {
doThrottle()
info, err := n.client.DomainGetInfo(dc.Name)
var info *nc.DomainInfo
var err error
doWithRetry(func() error {
info, err = n.client.DomainGetInfo(dc.Name)
return err
})
if err != nil {
return nil, err
}
@ -240,13 +248,12 @@ func (n *Namecheap) GetRegistrarCorrections(dc *models.DomainConfig) ([]*models.
return []*models.Correction{
{
Msg: fmt.Sprintf("Change Nameservers from '%s' to '%s'", found, desired),
F: func() error {
doThrottle()
_, err := n.client.DomainDNSSetCustom(sld, tld, desired)
if err != nil {
F: func() (err error) {
doWithRetry(func() error {
_, err = n.client.DomainDNSSetCustom(sld, tld, desired)
return err
}
return nil
})
return
}},
}, nil
}