From 997e1a09016f2d11c81e3ee9b5a7fe1d0df9f026 Mon Sep 17 00:00:00 2001 From: Tom Limoncelli Date: Mon, 23 May 2022 13:27:53 -0400 Subject: [PATCH] BUGFIX: Skip AuditRecords when running dnscontrol check (#1508) Fixes 1507 --- pkg/normalize/validate.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/normalize/validate.go b/pkg/normalize/validate.go index 26ae6bca0..f050ea70f 100644 --- a/pkg/normalize/validate.go +++ b/pkg/normalize/validate.go @@ -467,6 +467,12 @@ func ValidateAndNormalizeConfig(config *models.DNSConfig) (errs []error) { // Let's ask the provider if there are any records they can't handle. for _, domain := range config.Domains { // For each domain.. for _, provider := range domain.DNSProviderInstances { // For each provider... + if provider.ProviderBase.ProviderType == "-" { + // The point of "dnscontrol check" is that it doesn't require + // creds.json. Since the ProviderType is in creds.json, these + // pre-providerType checks must be skipped. + continue + } if err := providers.AuditRecords(provider.ProviderBase.ProviderType, domain.Records); err != nil { errs = append(errs, err) }