StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-09-06 05:04:29 +08:00
Code Issues Projects Releases Packages Wiki Activity

Support RFC 7505 "null MX" (#702) (#703)

Browse source 
* Fix #702: Spurious null MX changes on CloudFlare

* Test roundtripping null MX on Cloudflare

* Use an if instead of TrimSuffix

* Add other providers that support RFC 7505

* Suppress test for non-compliant providers
This commit is contained in:
PJ Eby 2020-03-25 09:53:28 -04:00 • committed by GitHub
parent 50d52775f8
commit a3ef53574c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
integrationTest/integration_test.go
View file

@ -609,6 +609,11 @@ func makeTests(t *testing.T) []*TestGroup {
tc("Record pointing to @", mx("foo", 8, "**current-domain**")), tc("Record pointing to @", mx("foo", 8, "**current-domain**")),
), ),
testgroup("Null MX",
not("AZURE_DNS", "GANDI_V5", "NAMEDOTCOM", "DIGITALOCEAN"), // These providers don't support RFC 7505
tc("Null MX", mx("@", 0, ".")),
),
testgroup("NS", testgroup("NS",
not("DNSIMPLE", "EXOSCALE"), not("DNSIMPLE", "EXOSCALE"),
// DNSIMPLE: Does not support NS records nor subdomains. // DNSIMPLE: Does not support NS records nor subdomains.

4
providers/cloudflare/cloudflareProvider.go
View file

@ -541,7 +541,9 @@ type cfRecord struct {
func (c *cfRecord) nativeToRecord(domain string) *models.RecordConfig { func (c *cfRecord) nativeToRecord(domain string) *models.RecordConfig {
// normalize cname,mx,ns records with dots to be consistent with our config format. // normalize cname,mx,ns records with dots to be consistent with our config format.
if c.Type == "CNAME" || c.Type == "MX" || c.Type == "NS" || c.Type == "SRV" { if c.Type == "CNAME" || c.Type == "MX" || c.Type == "NS" || c.Type == "SRV" {
c.Content = dnsutil.AddOrigin(c.Content+".", domain) if c.Content != "." {
c.Content = c.Content + "."
}
} }
rc := &models.RecordConfig{ rc := &models.RecordConfig{