StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-10-04 19:05:30 +08:00
Code Issues Projects Releases Packages Wiki Activity

DNSIMPLE: Adopt diff2 in compatibility mode (#1878)

Browse source
This commit is contained in:
Tom Limoncelli 2023-01-03 11:58:21 -05:00 • committed by GitHub
parent 347808f030
commit a498679c72
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 37 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
providers/dnsimple/dnsimpleProvider.go
View file

@ -165,10 +165,18 @@ func (c *dnsimpleProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*mod
// Normalize // Normalize
models.PostProcessRecords(actual) models.PostProcessRecords(actual)
if !diff2.EnableDiff2 || true { // Remove "|| true" when diff2 version arrives var create, del, modify diff.Changeset
if !diff2.EnableDiff2 {
differ := diff.New(dc) differ := diff.New(dc)
_, create, del, modify, err := differ.IncrementalDiff(actual) _, create, del, modify, err = differ.IncrementalDiff(actual)
} else {
differ := diff.NewCompat(dc)
_, create, del, modify, err = differ.IncrementalDiff(actual)
}
if err != nil {
return nil, err
}
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -201,11 +209,6 @@ func (c *dnsimpleProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*mod
return corrections, nil return corrections, nil
} }
// Insert Future diff2 version here.
return corrections, nil
}
func removeApexNS(records models.Records) models.Records { func removeApexNS(records models.Records) models.Records {
var filtered models.Records var filtered models.Records
for _, r := range records { for _, r := range records {