StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-02-24 07:33:03 +08:00
Code Issues Projects Releases Packages Wiki Activity

ROUTE53: Report R53_ALIAS loops as an error (#2111)

Browse source
This commit is contained in:
Tom Limoncelli 2023-03-01 10:00:58 -05:00 committed by GitHub
parent 0d2a7bf93e
commit b54c5eab10
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
integrationTest/integration_test.go
View file

@ -1256,6 +1256,16 @@ func makeTests(t *testing.T) []*TestGroup {
),
),
testgroup("R53_ALIAS_Loop",
// This will always be skipped because rejectifTargetEqualsLabel
// will always flag it as not permitted.
// See https://github.com/StackExchange/dnscontrol/issues/2107
requires(providers.CanUseRoute53Alias),
tc("loop should fail",
r53alias("test-islandora", "CNAME", "test-islandora.**current-domain**"),
),
),
// CLOUDFLAREAPI features
testgroup("CF_REDIRECT",

23
providers/route53/auditrecords.go
View file

@ -1,10 +1,31 @@
package route53
import "github.com/StackExchange/dnscontrol/v3/models"
import (
"fmt"
"github.com/StackExchange/dnscontrol/v3/models"
"github.com/StackExchange/dnscontrol/v3/pkg/rejectif"
)
// AuditRecords returns a list of errors corresponding to the records
// that aren't supported by this provider. If all records are
// supported, an empty list is returned.
func AuditRecords(records []*models.RecordConfig) []error {
a := rejectif.Auditor{}
a.Add("R53_ALIAS", rejectifTargetEqualsLabel) // Last verified 2023-03-01
return a.Audit(records)
}
// Normally this kind of function would be put in `pkg/rejectif` but
// since this is ROUTE53-specific, we'll include it here.
// rejectifTargetEqualsLabel rejects an ALIAS that would create a loop.
func rejectifTargetEqualsLabel(rc *models.RecordConfig) error {
if (rc.GetLabelFQDN() + ".") == rc.GetTargetField() {
return fmt.Errorf("alias target loop")
}
return nil
}