StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-12-18 22:58:45 +08:00
Code Issues Projects Releases Packages Wiki Activity

BUGFIX: Domains with Unicode should convert to IDN earlier

Browse source
This commit is contained in:
Thomas Limoncelli 2025-11-21 10:46:05 -05:00
parent bba3d4fbb8
commit c7f625a502
No known key found for this signature in database
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/normalize/validate.go
View file

@ -14,6 +14,7 @@ import (
"github.com/StackExchange/dnscontrol/v4/providers" "github.com/StackExchange/dnscontrol/v4/providers"
"github.com/miekg/dns" "github.com/miekg/dns"
"github.com/miekg/dns/dnsutil" "github.com/miekg/dns/dnsutil"
"golang.org/x/net/idna"
) )
// Returns false if target does not validate. // Returns false if target does not validate.
@ -359,6 +360,15 @@ func ValidateAndNormalizeConfig(config *models.DNSConfig) (errs []error) {
} }
for _, domain := range config.Domains { for _, domain := range config.Domains {
// Convert domain name to punycode.
// In the future, we should do something more sophisticated like having a .Name/.NameUnicode/.NameIDN so that users can see.
var err error
domain.Name, err = idna.ToASCII(domain.Name)
if err != nil {
return []error{fmt.Errorf("Can not convert domain %q to IDN: %w", domain.Name, err)}
}
pTypes := []string{} pTypes := []string{}
for _, provider := range domain.DNSProviderInstances { for _, provider := range domain.DNSProviderInstances {
pType := provider.ProviderType pType := provider.ProviderType