From cc6f5eb8d4091df93ccf24c1725348480de30ea0 Mon Sep 17 00:00:00 2001 From: Tom Limoncelli Date: Fri, 4 Mar 2022 09:42:36 -0500 Subject: [PATCH] fixup! (#1441) --- docs/_providers/cloudflare.md | 3 ++- integrationTest/integration_test.go | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/_providers/cloudflare.md b/docs/_providers/cloudflare.md index 9e1cd0e6c..3b2271f1d 100644 --- a/docs/_providers/cloudflare.md +++ b/docs/_providers/cloudflare.md @@ -10,7 +10,8 @@ This is the provider for [Cloudflare](https://www.cloudflare.com/). ## Important notes -* When using `SPF()` or the `SPF_BUILDER()` the records are converted to RecordType `TXT` as Cloudflare API fails otherwise. See more [here](https://github.com/StackExchange/dnscontrol/issues/446). +* SPF records are silently converted to RecordType `TXT` as Cloudflare API fails otherwise. See [StackExchange/dnscontrol#446](https://github.com/StackExchange/dnscontrol/issues/446). +* This provider currently fails if there are more than 1000 corrections on one domain. This only affects "push". This usually when moving a domain with many records to Cloudflare. Try commenting out most records, then uncomment groups of 999. Typical updates are less than 1000 corrections and will not trigger this bug. See [StackExchange/dnscontrol#1440](https://github.com/StackExchange/dnscontrol/issues/1440). ## Configuration diff --git a/integrationTest/integration_test.go b/integrationTest/integration_test.go index 181bd5f0a..3ee6bd05b 100644 --- a/integrationTest/integration_test.go +++ b/integrationTest/integration_test.go @@ -1052,11 +1052,12 @@ func makeTests(t *testing.T) []*TestGroup { testgroup("pager1201", only( - //"MSDNS", // No paging done. No need to test. - //"AKAMAIEDGEDNS", // No paging done. No need to test. + //"AKAMAIEDGEDNS", // No paging done. No need to test. //"AZURE_DNS", // Currently failing. See https://github.com/StackExchange/dnscontrol/issues/770 + //"CLOUDFLAREAPI", // Fails with >1000 corrections. See https://github.com/StackExchange/dnscontrol/issues/1440 "HEXONET", "HOSTINGDE", + //"MSDNS", // No paging done. No need to test. "ROUTE53", ), tc("1200 records", manyA("rec%04d", "1.2.3.4", 1200)...),