StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-10-07 20:39:59 +08:00
Code Issues Projects Releases Packages Wiki Activity

NS1: Fix NAPTR special case

Browse source
This commit is contained in:
Tom Limoncelli 2025-10-01 17:12:54 -04:00
parent 2122390f29
commit d026c26eb0
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
providers/ns1/records.go
View file

@ -201,6 +201,14 @@ func convert(zr *dns.ZoneRecord, domain string) ([]*models.RecordConfig, error)
if err := rec.SetTargetCAAStrings(xAns[0], xAns[1], xAns[2]); err != nil { if err := rec.SetTargetCAAStrings(xAns[0], xAns[1], xAns[2]); err != nil {
return nil, fmt.Errorf("unparsable %s record received from ns1: %w", rtype, err) return nil, fmt.Errorf("unparsable %s record received from ns1: %w", rtype, err)
} }
case "NAPTR":
// NB(tlim): This is a stupid hack. NS1 doesn't quote a missing
// parameter properly. Therefore we look for 2 spaces and assume there is
// a missing item.
ans = strings.ReplaceAll(ans, " ", " . ")
if err := rec.PopulateFromString(rtype, ans, domain); err != nil {
return nil, fmt.Errorf("unparsable record received from ns1: %w", err)
}
case "REDIRECT": case "REDIRECT":
// NS1 returns REDIRECTs as records, but there is only one and dummy answer: // NS1 returns REDIRECTs as records, but there is only one and dummy answer:
// "NS1 MANAGED RECORD" // "NS1 MANAGED RECORD"