GCLOUD: Fix issue on creating/deleting/updating TXT records (#3011)

Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>
This commit is contained in:
Karol Lassak 2024-06-17 16:46:31 +02:00 committed by GitHub
parent 174fd7b1ac
commit d55474ca69
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -271,11 +271,11 @@ func (g *gcloudProvider) GetZoneRecordsCorrections(dc *models.DomainConfig, exis
case diff2.CHANGE:
newMsgs = change.Msgs
newAdds = mkRRSs(n, ty, change.New)
newDels = mkRRSs(n, ty, change.Old)
newDels = change.Old[0].Original.(*gdns.ResourceRecordSet)
case diff2.DELETE:
newMsgs = change.Msgs
newAdds = nil
newDels = mkRRSs(n, ty, change.Old)
newDels = change.Old[0].Original.(*gdns.ResourceRecordSet)
default:
return nil, fmt.Errorf("GCLOUD unhandled change.TYPE %s", change.Type)
}
@ -403,6 +403,7 @@ func nativeToRecord(set *gdns.ResourceRecordSet, rec, origin string) (*models.Re
r.SetLabelFromFQDN(set.Name, origin)
r.TTL = uint32(set.Ttl)
rtype := set.Type
r.Original = set
err := r.PopulateFromStringFunc(rtype, rec, origin, txtutil.ParseQuoted)
if err != nil {
return nil, fmt.Errorf("unparsable record %q received from GCLOUD: %w", rtype, err)