StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-12-09 05:36:27 +08:00
Code Issues Projects Releases Packages Wiki Activity

TESTING: increase minimum TTL values in tests

Browse source
This commit is contained in:
artin 2025-12-04 00:35:18 +08:00
parent 00f1bd8e85
commit dbdec14486
3 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
integrationTest/helpers_integration_test.go
View file

@ -433,7 +433,7 @@ func loc(name string, d1 uint8, m1 uint8, s1 float32, ns string,
func makeRec(name, target, typ string) *models.RecordConfig { func makeRec(name, target, typ string) *models.RecordConfig {
r := &models.RecordConfig{ r := &models.RecordConfig{
Type: typ, Type: typ,
TTL: 300, TTL: 600,
} }
SetLabel(r, name, "**current-domain**.") SetLabel(r, name, "**current-domain**.")
r.MustSetTarget(target) r.MustSetTarget(target)

10
integrationTest/integration_test.go
View file

@ -216,7 +216,7 @@ func makeTests() []*TestGroup {
testgroup("Attl", testgroup("Attl",
not("LINODE"), // Linode does not support arbitrary TTLs: both are rounded up to 3600. not("LINODE"), // Linode does not support arbitrary TTLs: both are rounded up to 3600.
tc("Create Arc", ttl(a("testa", "1.1.1.1"), 333)), tc("Create Arc", ttl(a("testa", "1.1.1.1"), 666)),
tc("Change TTL", ttl(a("testa", "1.1.1.1"), 999)), tc("Change TTL", ttl(a("testa", "1.1.1.1"), 999)),
), ),
@ -226,7 +226,7 @@ func makeTests() []*TestGroup {
tc("Start", ttl(a("@", "8.8.8.8"), 666), a("www", "1.2.3.4"), a("www", "5.6.7.8")), tc("Start", ttl(a("@", "8.8.8.8"), 666), a("www", "1.2.3.4"), a("www", "5.6.7.8")),
tc("Change a ttl", ttl(a("@", "8.8.8.8"), 1000), a("www", "1.2.3.4"), a("www", "5.6.7.8")), tc("Change a ttl", ttl(a("@", "8.8.8.8"), 1000), a("www", "1.2.3.4"), a("www", "5.6.7.8")),
tc("Change single target from set", ttl(a("@", "8.8.8.8"), 1000), a("www", "2.2.2.2"), a("www", "5.6.7.8")), tc("Change single target from set", ttl(a("@", "8.8.8.8"), 1000), a("www", "2.2.2.2"), a("www", "5.6.7.8")),
tc("Change all ttls", ttl(a("@", "8.8.8.8"), 500), ttl(a("www", "2.2.2.2"), 400), ttl(a("www", "5.6.7.8"), 400)), tc("Change all ttls", ttl(a("@", "8.8.8.8"), 900), ttl(a("www", "2.2.2.2"), 800), ttl(a("www", "5.6.7.8"), 700)),
), ),
// Narrative: Did you see that `not("NETCUP")` code? NETCUP just // Narrative: Did you see that `not("NETCUP")` code? NETCUP just
@ -245,8 +245,8 @@ func makeTests() []*TestGroup {
// Next we add an additional record at the same label AND change // Next we add an additional record at the same label AND change
// the TTL of the existing record. // the TTL of the existing record.
testgroup("add to label and change orig ttl", testgroup("add to label and change orig ttl",
tc("Setup", ttl(a("www", "5.6.7.8"), 400)), tc("Setup", ttl(a("www", "5.6.7.8"), 700)),
tc("Add at same label, new ttl", ttl(a("www", "5.6.7.8"), 700), ttl(a("www", "1.2.3.4"), 700)), tc("Add at same label, new ttl", ttl(a("www", "5.6.7.8"), 1000), ttl(a("www", "1.2.3.4"), 1000)),
), ),
// Narrative: We're done with TTL tests now. If you fixed a bug // Narrative: We're done with TTL tests now. If you fixed a bug
@ -807,7 +807,7 @@ func makeTests() []*TestGroup {
// https://github.com/StackExchange/dnscontrol/issues/2066 // https://github.com/StackExchange/dnscontrol/issues/2066
testgroup("SRV", testgroup("SRV",
requires(providers.CanUseSRV), requires(providers.CanUseSRV),
tc("Create SRV333", ttl(srv("_sip._tcp", 5, 6, 7, "foo.com."), 333)), tc("Create SRV666", ttl(srv("_sip._tcp", 5, 6, 7, "foo.com."), 666)),
tc("Change TTL999", ttl(srv("_sip._tcp", 5, 6, 7, "foo.com."), 999)), tc("Change TTL999", ttl(srv("_sip._tcp", 5, 6, 7, "foo.com."), 999)),
), ),

8
models/dns_test.go
View file

@ -22,11 +22,11 @@ func TestRR(t *testing.T) {
Name: "@", Name: "@",
NameFQDN: "example.com", NameFQDN: "example.com",
target: "mailto:test@example.com", target: "mailto:test@example.com",
TTL: 300, TTL: 600,
CaaTag: "iodef", CaaTag: "iodef",
CaaFlag: 1, CaaFlag: 1,
} }
expected = "example.com.\t300\tIN\tCAA\t1 iodef \"mailto:test@example.com\"" expected = "example.com.\t600\tIN\tCAA\t1 iodef \"mailto:test@example.com\""
found = experiment.ToRR().String() found = experiment.ToRR().String()
if found != expected { if found != expected {
t.Errorf("RR expected (%#v) got (%#v)\n", expected, found) t.Errorf("RR expected (%#v) got (%#v)\n", expected, found)
@ -37,12 +37,12 @@ func TestRR(t *testing.T) {
Name: "@", Name: "@",
NameFQDN: "_443._tcp.example.com", NameFQDN: "_443._tcp.example.com",
target: "abcdef0123456789", target: "abcdef0123456789",
TTL: 300, TTL: 600,
TlsaUsage: 0, TlsaUsage: 0,
TlsaSelector: 0, TlsaSelector: 0,
TlsaMatchingType: 1, TlsaMatchingType: 1,
} }
expected = "_443._tcp.example.com.\t300\tIN\tTLSA\t0 0 1 abcdef0123456789" expected = "_443._tcp.example.com.\t600\tIN\tTLSA\t0 0 1 abcdef0123456789"
found = experiment.ToRR().String() found = experiment.ToRR().String()
if found != expected { if found != expected {
t.Errorf("RR expected (%#v) got (%#v)\n", expected, found) t.Errorf("RR expected (%#v) got (%#v)\n", expected, found)