StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-09-10 23:24:39 +08:00
Code Issues Projects Releases Packages Wiki Activity

FEATURE: Detect simple CNAME loops (#2112)

Browse source
This commit is contained in:
Tom Limoncelli 2023-03-01 10:15:41 -05:00 • committed by GitHub
parent b54c5eab10
commit dde7e5daf7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/normalize/validate.go
View file

@ -187,6 +187,11 @@ func checkTargets(rec *models.RecordConfig, domain string) (errs []error) {
if label == "@" { if label == "@" {
check(fmt.Errorf("cannot create CNAME record for bare domain")) check(fmt.Errorf("cannot create CNAME record for bare domain"))
} }
labelFQDN := dnsutil.AddOrigin(label, domain)
targetFQDN := dnsutil.AddOrigin(target, domain)
if labelFQDN == targetFQDN {
check(fmt.Errorf("CNAME loop (target points at itself)"))
}
case "MX": case "MX":
check(checkTarget(target)) check(checkTarget(target))
case "NAPTR": case "NAPTR":