StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-09-08 14:15:30 +08:00
Code Issues Projects Releases Packages Wiki Activity

(#667) Remove unneeded SSHFP integration test (#677)

Browse source 
The test 49 was changing the fingerprint type of a SSHFP DNS RR,
but not the fingerprint hash. Changing the type of hash function
changes the hash result size (there's only two defined hash type of
different size in the RFC, SHA-1 and SHA-256).
This was failing with the OVH provider, because OVH is validating
the hash sizes of any created SSHFP RR and was finding an inconsistency.
Since there's already the test 50 which is both changing the type
and the fingerprint, the functionality is still covered and we
can remove test 49.
This commit is contained in:
Brice Figureau 2020-03-02 17:23:47 +01:00 • committed by GitHub
parent a3f103e97f
commit e082c74de2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
integrationTest/integration_test.go
View file

@ -473,9 +473,7 @@ func makeTests(t *testing.T) []*TestCase {
sshfp("@", 1, 1, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")),
tc("SSHFP change algorithm",
sshfp("@", 2, 1, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")),
tc("SSHFP change type",
sshfp("@", 2, 2, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")),
tc("SSHFP change fingerprint",
tc("SSHFP change fingerprint and type",
sshfp("@", 2, 2, "745a635bc46a397a5c4f21d437483005bcc40d7511ff15fbfafe913a081559bc")),
tc("SSHFP Delete one"),
tc("SSHFP add many records",

7
integrationTest/providers.json
View file

@ -2,7 +2,7 @@
"ACTIVEDIRECTORY_PS": {
"ADServer": "$AD_SERVER",
"domain": "$AD_DOMAIN",
"knownFailures": "29,30,31,32,33,34,35,38,39,40,41,48,49,51,52,53"
"knownFailures": "29,30,31,32,33,34,35,38,39,40,41,48,50,51,52"
},
"AZURE_DNS": {
"SubscriptionID": "$AZURE_SUBSCRIPTION_ID",
@ -19,7 +19,7 @@
"auth-id": "$CLOUDNS_AUTH_ID",
"auth-password": "$CLOUDNS_AUTH_PASSWORD",
"domain": "$CLOUDNS_DOMAIN",
"knownFailures": "53"
"knownFailures": "52"
},
"CLOUDFLAREAPI_OLD": {
@ -125,7 +125,6 @@
"app-key": "$OVH_APP_KEY",
"app-secret-key": "$OVH_APP_SECRET_KEY",
"consumer-key": "$OVH_CONSUMER_KEY",
"domain": "$OVH_DOMAIN",
"knownFailures": "49"
"domain": "$OVH_DOMAIN"
}
}