StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-09-11 23:54:28 +08:00
Code Issues Projects Releases Packages Wiki Activity

NS1: Handle assigned nameservers better (#2260)

Browse source
This commit is contained in:
Costas Drogos 2023-04-04 13:50:05 +02:00 • committed by GitHub
parent e230ade9c2
commit f25d5fa46a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
providers/ns1/ns1Provider.go
View file

@ -66,11 +66,26 @@ func (n *nsone) EnsureZoneExists(domain string) error {
} }
func (n *nsone) GetNameservers(domain string) ([]*models.Nameserver, error) { func (n *nsone) GetNameservers(domain string) ([]*models.Nameserver, error) {
var nservers []string
z, _, err := n.Zones.Get(domain) z, _, err := n.Zones.Get(domain)
if err != nil { if err != nil {
return nil, err return nil, err
} }
return models.ToNameserversStripTD(z.DNSServers)
// on newly-created domains NS1 may assign nameservers with or without a
// trailing dot. This is not reflected in the actual DNS records, that
// always have the trailing dots.
//
// Handle both scenarios by stripping dots where existing, before continuing.
for _, ns := range z.DNSServers {
if strings.HasSuffix(ns, ".") {
nservers = append(nservers, ns[0:len(ns)-1])
} else {
nservers = append(nservers, ns)
}
}
return models.ToNameservers(nservers)
} }
// GetZoneRecords gets the records of a zone and returns them in RecordConfig format. // GetZoneRecords gets the records of a zone and returns them in RecordConfig format.