mirror of
https://github.com/StackExchange/dnscontrol.git
synced 2025-12-09 13:46:07 +08:00
1b2f5d4d34
# Issue Fixes https://github.com/StackExchange/dnscontrol/issues/3842 CC @das7pad # Resolution Convert domain.Name to IDN earlier in the pipeline. Hack the --domains processing to convert everything to IDN. * Domain names are now stored 3 ways: The original input from dnsconfig.js, canonical IDN format (`xn--...`), and Unicode format. All are downcased. Providers that haven't been updated will receive the IDN format instead of the original input format. This might break some providers but only for users with unicode in their D("domain.tld"). PLEASE TEST YOUR PROVIDER. * BIND filename formatting options have been added to access the new formats. # Breaking changes * BIND zonefiles may change. The default used the name input in the D() statement. It now defaults to the IDN name + "!tag" if there is a tag. * Providers that are not IDN-aware may break (hopefully only if they weren't processing IDN already) --------- Co-authored-by: Jakob Ackermann <das7pad@outlook.com>
102 lines
3.3 KiB
Go
102 lines
3.3 KiB
Go
package powerdns
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/StackExchange/dnscontrol/v4/models"
|
|
"github.com/StackExchange/dnscontrol/v4/pkg/diff2"
|
|
"github.com/fatih/color"
|
|
"github.com/mittwald/go-powerdns/apis/zones"
|
|
)
|
|
|
|
func (dsp *powerdnsProvider) getDiff2DomainCorrections(dc *models.DomainConfig, existing models.Records) ([]*models.Correction, int, error) {
|
|
changes, actualChangeCount, err := diff2.ByRecordSet(existing, dc, nil)
|
|
if err != nil {
|
|
return nil, 0, err
|
|
}
|
|
|
|
var corrections []*models.Correction
|
|
var changeMsgs []string
|
|
var rrChangeSets []zones.ResourceRecordSet
|
|
var deleteMsgs []string
|
|
var rrDeleteSets []zones.ResourceRecordSet
|
|
|
|
// for pretty alignment, add an empty string
|
|
changeMsgs = append(changeMsgs, color.YellowString("± BATCHED CHANGE/CREATEs for %s", dc.Name))
|
|
deleteMsgs = append(deleteMsgs, color.RedString("- BATCHED DELETEs for %s", dc.Name))
|
|
|
|
for _, change := range changes {
|
|
labelName := canonical(change.Key.NameFQDN)
|
|
labelType := change.Key.Type
|
|
|
|
switch change.Type {
|
|
case diff2.REPORT:
|
|
corrections = append(corrections, &models.Correction{Msg: change.MsgsJoined})
|
|
case diff2.CREATE, diff2.CHANGE:
|
|
labelTTL := int(change.New[0].TTL)
|
|
records := buildRecordList(change)
|
|
|
|
rrChangeSets = append(rrChangeSets, zones.ResourceRecordSet{
|
|
Name: labelName,
|
|
Type: labelType,
|
|
TTL: labelTTL,
|
|
Records: records,
|
|
// ChangeType is not needed since zone API sets it when calling Add
|
|
})
|
|
changeMsgs = append(changeMsgs, change.MsgsJoined)
|
|
case diff2.DELETE:
|
|
rrDeleteSets = append(rrDeleteSets, zones.ResourceRecordSet{
|
|
Name: labelName,
|
|
Type: labelType,
|
|
// ChangeType is not needed since zone API sets it when calling Remove
|
|
})
|
|
deleteMsgs = append(deleteMsgs, change.MsgsJoined)
|
|
default:
|
|
panic(fmt.Sprintf("unhandled change.Type %s", change.Type))
|
|
}
|
|
}
|
|
|
|
domainVariant := dsp.zoneName(dc.Name, dc.Tag)
|
|
|
|
// only append a Correction if there are any, otherwise causes an error when sending an empty rrset
|
|
if len(rrDeleteSets) > 0 {
|
|
corrections = append(corrections, &models.Correction{
|
|
Msg: strings.Join(deleteMsgs, "\n"),
|
|
F: func() error {
|
|
return dsp.client.Zones().RemoveRecordSetsFromZone(context.Background(), dsp.ServerName, domainVariant, rrDeleteSets)
|
|
},
|
|
})
|
|
}
|
|
if len(rrChangeSets) > 0 {
|
|
corrections = append(corrections, &models.Correction{
|
|
Msg: strings.Join(changeMsgs, "\n"),
|
|
F: func() error {
|
|
return dsp.client.Zones().AddRecordSetsToZone(context.Background(), dsp.ServerName, domainVariant, rrChangeSets)
|
|
},
|
|
})
|
|
}
|
|
return corrections, actualChangeCount, nil
|
|
}
|
|
|
|
// buildRecordList returns a list of records for the PowerDNS resource record set from a change
|
|
func buildRecordList(change diff2.Change) (records []zones.Record) {
|
|
for _, recordContent := range change.New {
|
|
record := zones.Record{
|
|
Content: recordContent.GetTargetCombined(),
|
|
}
|
|
if recordContent.Type == "HTTPS" || recordContent.Type == "SVCB" {
|
|
// PowerDNS API will return HTTP 422 error if record content contains double quotes.
|
|
// Remove double quotes to work around this limitation.
|
|
// e.g. `1 . alpn="h3,h2"` ==> `1 . alpn=h3,h2`
|
|
record.Content = strings.ReplaceAll(record.Content, "\"", "")
|
|
}
|
|
records = append(records, record)
|
|
}
|
|
return
|
|
}
|
|
|
|
func canonical(fqdn string) string {
|
|
return fqdn + "."
|
|
}
|