mirror of
https://github.com/StackExchange/dnscontrol.git
synced 2025-12-09 13:46:07 +08:00
1e67585e8f
Closes https://github.com/StackExchange/dnscontrol/issues/3787
This PR is adding a `HETZNER_V2` provider for the "new" Hetzner DNS API.
Testing:
- The integration tests are passing.
- Manual testing:
- `preview` (see diff for existing zone)
- `preview --populate-on-preview` (see full diff for newly created zone)
- `push` (see full diff; no diff after push)
- `push` (see full diff; no diff after push to newly created zone --
i.e. single pass and done)
```js
var REG_NONE = NewRegistrar('none')
var DSP = NewDnsProvider('HETZNER_V2')
D('testing-2025-11-14-7.dev', REG_NONE, DnsProvider(DSP),
A('@', '127.0.0.1')
)
```
<details>
```
# push for newly created zone
CONCURRENTLY checking for 1 zone(s)
SERIALLY checking for 0 zone(s)
Waiting for concurrent checking(s) to complete...DONE
******************** Domain: testing-2025-11-14-7.dev
1 correction (HETZNER_V2)
#1: Ensuring zone "testing-2025-11-14-7.dev" exists in "HETZNER_V2"
SUCCESS!
CONCURRENTLY gathering records of 1 zone(s)
SERIALLY gathering records of 0 zone(s)
Waiting for concurrent gathering(s) to complete...DONE
******************** Domain: testing-2025-11-14-7.dev
4 corrections (HETZNER_V2)
#1: ± MODIFY-TTL testing-2025-11-14-7.dev NS helium.ns.hetzner.de. ttl=(3600->300)
± MODIFY-TTL testing-2025-11-14-7.dev NS hydrogen.ns.hetzner.com. ttl=(3600->300)
± MODIFY-TTL testing-2025-11-14-7.dev NS oxygen.ns.hetzner.com. ttl=(3600->300)
SUCCESS!
#2: + CREATE testing-2025-11-14-7.dev A 127.0.0.1 ttl=300
SUCCESS!
Done. 5 corrections.
```
</details>
Feedback for @jooola and @LKaemmerling:
- The SDK was very useful in getting 80% there! Nice! 🎉
- Footgun:
- The `result` values are not "up-to-date" after waiting for an
`Action`, e.g. `Zone.AuthoritativeNameservers.Assigned` is not set when
`Client.Zone.Create()` returns and the following "wait" will not update
it.
- Taking a step back here: Waiting for an `Action` with a separate SDK
call does not seem very natural to me. Does the SDK-user need to know
that you are processing operations asynchronous? (Which seems like an
implementation detail to me, something that the SDK could abstrct over.)
Can `Client.Zone.Create()` return the final `Zone` instead of the
intermediate result?
- Features missing compared to the DNS Console, in priority order:
- It is no longer possible to remove your provided name servers from the
root/apex. Use-case: dual-home/multi-home zone with fewer than three
servers from Hetzner. I'm operating one of these and cannot migrate over
until this is fixed.
- Performance regression due to lack of bulk create/modify. E.g. [one of
the test
suites](
|
||
|---|---|---|
| .. | ||
| _all | ||
| adguardhome | ||
| akamaiedgedns | ||
| autodns | ||
| axfrddns | ||
| azuredns | ||
| azureprivatedns | ||
| bind | ||
| bunnydns | ||
| cloudflare | ||
| cloudns | ||
| cnr | ||
| cscglobal | ||
| desec | ||
| digitalocean | ||
| dnsimple | ||
| dnsmadeeasy | ||
| doh | ||
| domainnameshop | ||
| dynadot | ||
| easyname | ||
| exoscale | ||
| fortigate | ||
| gandiv5 | ||
| gcloud | ||
| gcore | ||
| hedns | ||
| hetzner | ||
| hetznerv2 | ||
| hexonet | ||
| hostingde | ||
| huaweicloud | ||
| internetbs | ||
| inwx | ||
| joker | ||
| linode | ||
| loopia | ||
| luadns | ||
| mythicbeasts | ||
| namecheap | ||
| namedotcom | ||
| netcup | ||
| netlify | ||
| ns1 | ||
| opensrs | ||
| oracle | ||
| ovh | ||
| packetframe | ||
| porkbun | ||
| powerdns | ||
| realtimeregister | ||
| route53 | ||
| rwth | ||
| sakuracloud | ||
| softlayer | ||
| transip | ||
| vultr | ||
| capabilities.go | ||
| capability_string.go | ||
| providers.go | ||