mirror of
https://github.com/StackExchange/dnscontrol.git
synced 2024-09-20 14:56:20 +08:00
8dea9edc34
TXT records are now handled different. 1. The raw input from dnsconfig.js is passed all the way to the provider. The provider can determine if it can or can't handle such records (auditrecords.go) and processes them internally as such. 2. The CanUseTXTMulti capability is no longer needed. * DSPs now register a table of functions * Use audits for txt record variations * unit tests pass. integration fails. * fix deepcopy problem * rename to AuditRecordSupport * Reduce use of TXTMulti * Remove CanUseTXTMulti * fix Test Skip * fix DO * fix vultr * fix NDC * msdns fixes * Fix powerdns and cloudflare * HEDNS: Fix usage of target field to resolve TXT handling (#1067) * Fix HEXONET Co-authored-by: Robert Blenkinsopp <robert@blenkinsopp.net> Co-authored-by: Jakob Ackermann <das7pad@outlook.com>
108 lines
2.6 KiB
Go
108 lines
2.6 KiB
Go
package hetzner
|
|
|
|
import (
|
|
"github.com/StackExchange/dnscontrol/v3/models"
|
|
"strings"
|
|
)
|
|
|
|
type bulkCreateRecordsRequest struct {
|
|
Records []record `json:"records"`
|
|
}
|
|
|
|
type bulkUpdateRecordsRequest struct {
|
|
Records []record `json:"records"`
|
|
}
|
|
|
|
type createRecordRequest struct {
|
|
Name string `json:"name"`
|
|
TTL int `json:"ttl"`
|
|
Type string `json:"type"`
|
|
Value string `json:"value"`
|
|
ZoneID string `json:"zone_id"`
|
|
}
|
|
|
|
type createZoneRequest struct {
|
|
Name string `json:"name"`
|
|
}
|
|
|
|
type getAllRecordsResponse struct {
|
|
Records []record `json:"records"`
|
|
Meta struct {
|
|
Pagination struct {
|
|
LastPage int `json:"last_page"`
|
|
} `json:"pagination"`
|
|
} `json:"meta"`
|
|
}
|
|
|
|
type getAllZonesResponse struct {
|
|
Zones []zone `json:"zones"`
|
|
Meta struct {
|
|
Pagination struct {
|
|
LastPage int `json:"last_page"`
|
|
} `json:"pagination"`
|
|
} `json:"meta"`
|
|
}
|
|
|
|
type record struct {
|
|
ID string `json:"id"`
|
|
Name string `json:"name"`
|
|
TTL *int `json:"ttl"`
|
|
Type string `json:"type"`
|
|
Value string `json:"value"`
|
|
ZoneID string `json:"zone_id"`
|
|
}
|
|
|
|
type zone struct {
|
|
ID string `json:"id"`
|
|
Name string `json:"name"`
|
|
NameServers []string `json:"ns"`
|
|
TTL int `json:"ttl"`
|
|
}
|
|
|
|
func fromRecordConfig(in *models.RecordConfig, zone *zone) *record {
|
|
ttl := int(in.TTL)
|
|
record := &record{
|
|
Name: in.GetLabel(),
|
|
Type: in.Type,
|
|
Value: in.GetTargetCombined(),
|
|
TTL: &ttl,
|
|
ZoneID: zone.ID,
|
|
}
|
|
|
|
if record.Type == "TXT" && len(in.TxtStrings) == 1 {
|
|
// HACK: HETZNER rejects values that fit into 255 bytes w/o quotes,
|
|
// but do not fit w/ added quotes (via GetTargetCombined()).
|
|
// Sending the raw, non-quoted value works for the comprehensive
|
|
// suite of integrations tests.
|
|
// The HETZNER validation does not provide helpful error messages.
|
|
// {"error":{"message":"422 Unprocessable Entity: missing: ; ","code":422}}
|
|
valueNotQuoted := in.TxtStrings[0]
|
|
if len(valueNotQuoted) == 254 || len(valueNotQuoted) == 255 {
|
|
record.Value = valueNotQuoted
|
|
}
|
|
}
|
|
|
|
return record
|
|
}
|
|
|
|
func toRecordConfig(domain string, record *record) *models.RecordConfig {
|
|
rc := &models.RecordConfig{
|
|
Type: record.Type,
|
|
TTL: uint32(*record.TTL),
|
|
Original: record,
|
|
}
|
|
rc.SetLabel(record.Name, domain)
|
|
|
|
value := record.Value
|
|
// HACK: Hetzner is inserting a trailing space after multiple, quoted values.
|
|
// NOTE: The actual DNS answer does not contain the space.
|
|
if record.Type == "TXT" && len(value) > 0 && value[len(value)-1] == ' ' {
|
|
// Per RFC 1035 spaces outside quoted values are irrelevant.
|
|
value = strings.TrimRight(value, " ")
|
|
}
|
|
|
|
_ = rc.PopulateFromString(record.Type, value, domain)
|
|
|
|
return rc
|
|
}
|