mirror of
https://github.com/StackExchange/dnscontrol.git
synced 2024-11-14 12:15:06 +08:00
7b8d608019
* Stable comparison of metadata (#239) Iterating over a map in Go never produces twice the same ordering. Thus when comparing two metadata map with more than one key, the `differ` is always finding differences. To properly compare records metadata, we need to iterate the maps in a deterministic way. Signed-off-by: Brice Figureau <brice@daysofwonder.com> * Support for Route53 ALIAS record type (#239) Route53 ALIAS doesn't behave like a regular ALIAS, and is much more limited as its target can only be some specific AWS resources or another record in the same zone. According to #239, this change adds a new directive R53_ALIAS which implements this specific alias. This record type can only be used with the Route53 provider. This directive usage looks like this: ```js D("example.com", REGISTRAR, DnsProvider("ROUTE53"), R53_ALIAS("foo1", "A", "bar") // record in same zone R53_ALIAS("foo2", "A", "blahblah.elasticloadbalancing.us-west-1.amazonaws.com", R53_ZONE('Z368ELLRRE2KJ0')) // ELB in us-west-1 ``` Unfortunately, Route53 requires indicating the hosted zone id where the target is defined (those are listed in AWS documentation, see the R53_ALIAS documentation for links).
227 lines
6.6 KiB
Go
227 lines
6.6 KiB
Go
package diff
|
|
|
|
import (
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/StackExchange/dnscontrol/models"
|
|
"github.com/miekg/dns/dnsutil"
|
|
)
|
|
|
|
func myRecord(s string) *models.RecordConfig {
|
|
parts := strings.Split(s, " ")
|
|
ttl, _ := strconv.ParseUint(parts[2], 10, 32)
|
|
return &models.RecordConfig{
|
|
Name: parts[0],
|
|
NameFQDN: dnsutil.AddOrigin(parts[0], "example.com"),
|
|
Type: parts[1],
|
|
TTL: uint32(ttl),
|
|
Target: parts[3],
|
|
Metadata: map[string]string{},
|
|
}
|
|
}
|
|
|
|
func TestAdditionsOnly(t *testing.T) {
|
|
desired := []*models.RecordConfig{
|
|
myRecord("@ A 1 1.2.3.4"),
|
|
}
|
|
existing := []*models.RecordConfig{}
|
|
checkLengths(t, existing, desired, 0, 1, 0, 0)
|
|
}
|
|
|
|
func TestDeletionsOnly(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("@ A 1 1.2.3.4"),
|
|
}
|
|
desired := []*models.RecordConfig{}
|
|
checkLengths(t, existing, desired, 0, 0, 1, 0)
|
|
}
|
|
|
|
func TestModification(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www A 1 1.1.1.1"),
|
|
myRecord("@ A 1 1.2.3.4"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("@ A 32 1.2.3.4"),
|
|
myRecord("www A 1 1.1.1.1"),
|
|
}
|
|
un, _, _, mod := checkLengths(t, existing, desired, 1, 0, 0, 1)
|
|
if un[0].Desired != desired[1] || un[0].Existing != existing[0] {
|
|
t.Error("Expected unchanged records to be correlated")
|
|
}
|
|
if mod[0].Desired != desired[0] || mod[0].Existing != existing[1] {
|
|
t.Errorf("Expected modified records to be correlated")
|
|
}
|
|
}
|
|
|
|
func TestUnchangedWithAddition(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www A 1 1.1.1.1"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("www A 1 1.2.3.4"),
|
|
myRecord("www A 1 1.1.1.1"),
|
|
}
|
|
un, _, _, _ := checkLengths(t, existing, desired, 1, 1, 0, 0)
|
|
if un[0].Desired != desired[1] || un[0].Existing != existing[0] {
|
|
t.Errorf("Expected unchanged records to be correlated")
|
|
}
|
|
}
|
|
|
|
func TestOutOfOrderRecords(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www A 1 1.1.1.1"),
|
|
myRecord("www A 1 2.2.2.2"),
|
|
myRecord("www A 1 3.3.3.3"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("www A 1 1.1.1.1"),
|
|
myRecord("www A 1 2.2.2.2"),
|
|
myRecord("www A 1 2.2.2.3"),
|
|
myRecord("www A 10 3.3.3.3"),
|
|
}
|
|
_, _, _, mods := checkLengths(t, existing, desired, 2, 1, 0, 1)
|
|
if mods[0].Desired != desired[3] || mods[0].Existing != existing[2] {
|
|
t.Fatalf("Expected to match %s and %s, but matched %s and %s", existing[2], desired[3], mods[0].Existing, mods[0].Desired)
|
|
}
|
|
}
|
|
|
|
func TestMxPrio(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www MX 1 1.1.1.1"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("www MX 1 1.1.1.1"),
|
|
}
|
|
existing[0].MxPreference = 10
|
|
desired[0].MxPreference = 20
|
|
checkLengths(t, existing, desired, 0, 0, 0, 1)
|
|
}
|
|
|
|
func TestTTLChange(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www MX 1 1.1.1.1"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("www MX 10 1.1.1.1"),
|
|
}
|
|
checkLengths(t, existing, desired, 0, 0, 0, 1)
|
|
}
|
|
|
|
func TestMetaChange(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www MX 1 1.1.1.1"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("www MX 1 1.1.1.1"),
|
|
}
|
|
existing[0].Metadata["k"] = "aa"
|
|
desired[0].Metadata["k"] = "bb"
|
|
checkLengths(t, existing, desired, 1, 0, 0, 0)
|
|
getMeta := func(r *models.RecordConfig) map[string]string {
|
|
return map[string]string{
|
|
"k": r.Metadata["k"],
|
|
}
|
|
}
|
|
checkLengths(t, existing, desired, 0, 0, 0, 1, getMeta)
|
|
}
|
|
|
|
func TestMetaOrdering(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www MX 1 1.1.1.1"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("www MX 1 1.1.1.1"),
|
|
}
|
|
existing[0].Metadata["k"] = "aa"
|
|
existing[0].Metadata["x"] = "cc"
|
|
desired[0].Metadata["k"] = "aa"
|
|
desired[0].Metadata["x"] = "cc"
|
|
checkLengths(t, existing, desired, 1, 0, 0, 0)
|
|
getMeta := func(r *models.RecordConfig) map[string]string {
|
|
return map[string]string{
|
|
"k": r.Metadata["k"],
|
|
}
|
|
}
|
|
checkLengths(t, existing, desired, 1, 0, 0, 0, getMeta)
|
|
}
|
|
|
|
func checkLengths(t *testing.T, existing, desired []*models.RecordConfig, unCount, createCount, delCount, modCount int, valFuncs ...func(*models.RecordConfig) map[string]string) (un, cre, del, mod Changeset) {
|
|
return checkLengthsWithKeepUnknown(t, existing, desired, unCount, createCount, delCount, modCount, false, valFuncs...)
|
|
}
|
|
|
|
func checkLengthsWithKeepUnknown(t *testing.T, existing, desired []*models.RecordConfig, unCount, createCount, delCount, modCount int, keepUnknown bool, valFuncs ...func(*models.RecordConfig) map[string]string) (un, cre, del, mod Changeset) {
|
|
return checkLengthsFull(t, existing, desired, unCount, createCount, delCount, modCount, keepUnknown, []string{}, valFuncs...)
|
|
}
|
|
|
|
func checkLengthsFull(t *testing.T, existing, desired []*models.RecordConfig, unCount, createCount, delCount, modCount int, keepUnknown bool, ignoredRecords []string, valFuncs ...func(*models.RecordConfig) map[string]string) (un, cre, del, mod Changeset) {
|
|
dc := &models.DomainConfig{
|
|
Name: "example.com",
|
|
Records: desired,
|
|
KeepUnknown: keepUnknown,
|
|
IgnoredLabels: ignoredRecords,
|
|
}
|
|
d := New(dc, valFuncs...)
|
|
un, cre, del, mod = d.IncrementalDiff(existing)
|
|
if len(un) != unCount {
|
|
t.Errorf("Got %d unchanged records, but expected %d", len(un), unCount)
|
|
}
|
|
if len(cre) != createCount {
|
|
t.Errorf("Got %d records to create, but expected %d", len(cre), createCount)
|
|
}
|
|
if len(del) != delCount {
|
|
t.Errorf("Got %d records to delete, but expected %d", len(del), delCount)
|
|
}
|
|
if len(mod) != modCount {
|
|
t.Errorf("Got %d records to modify, but expected %d", len(mod), modCount)
|
|
}
|
|
if t.Failed() {
|
|
t.FailNow()
|
|
}
|
|
return
|
|
}
|
|
|
|
func TestNoPurge(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www MX 1 1.1.1.1"),
|
|
myRecord("www MX 1 2.2.2.2"),
|
|
myRecord("www2 MX 1 1.1.1.1"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("www MX 1 1.1.1.1"),
|
|
}
|
|
checkLengthsWithKeepUnknown(t, existing, desired, 1, 0, 1, 0, true)
|
|
}
|
|
|
|
func TestIgnoredRecords(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www1 MX 1 1.1.1.1"),
|
|
myRecord("www2 MX 1 1.1.1.1"),
|
|
myRecord("www3 MX 1 1.1.1.1"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("www3 MX 1 2.2.2.2"),
|
|
}
|
|
checkLengthsFull(t, existing, desired, 0, 0, 0, 1, false, []string{"www1", "www2"})
|
|
}
|
|
|
|
func TestModifyingIgnoredRecords(t *testing.T) {
|
|
existing := []*models.RecordConfig{
|
|
myRecord("www1 MX 1 1.1.1.1"),
|
|
myRecord("www2 MX 1 1.1.1.1"),
|
|
myRecord("www3 MX 1 1.1.1.1"),
|
|
}
|
|
desired := []*models.RecordConfig{
|
|
myRecord("www2 MX 1 2.2.2.2"),
|
|
}
|
|
|
|
defer func() {
|
|
if r := recover(); r == nil {
|
|
t.Errorf("should panic: modification of IGNOREd record")
|
|
}
|
|
}()
|
|
|
|
checkLengthsFull(t, existing, desired, 0, 0, 0, 1, false, []string{"www1", "www2"})
|
|
}
|