mirror of
https://github.com/StackExchange/dnscontrol.git
synced 2025-12-09 05:36:27 +08:00
bcef7f52fc
<!--
## Before submiting a pull request
Please make sure you've run the following commands from the root
directory.
bin/generate-all.sh
(this runs commands like "go generate", fixes formatting, and so on)
## Release changelog section
Help keep the release changelog clear by pre-naming the proper section
in the GitHub pull request title.
Some examples:
* CICD: Add required GHA permissions for goreleaser
* DOCS: Fixed providers with "contributor support" table
* ROUTE53: Allow R53_ALIAS records to enable target health evaluation
More examples/context can be found in the file .goreleaser.yml under the
'build' > 'changelog' key.
!-->
https://github.com/StackExchange/dnscontrol/issues/420
Please create the GitHub label 'provider-ALIDNS'
---------
Co-authored-by: Tom Limoncelli <6293917+tlimoncelli@users.noreply.github.com>
64 lines
2.8 KiB
Go
64 lines
2.8 KiB
Go
package alidns
|
|
|
|
import (
|
|
"errors"
|
|
"unicode"
|
|
|
|
"github.com/StackExchange/dnscontrol/v4/models"
|
|
"github.com/StackExchange/dnscontrol/v4/pkg/rejectif"
|
|
)
|
|
|
|
// isValidAliDNSString checks if a string contains only ASCII or Chinese characters.
|
|
// Alibaba Cloud DNS allows: a-z, A-Z, 0-9, -, _, ., *, @, and Chinese characters (汉字).
|
|
func isValidAliDNSString(s string) bool {
|
|
for _, r := range s {
|
|
if r > unicode.MaxASCII {
|
|
// Allow CJK Unified Ideographs (Chinese characters): U+4E00 to U+9FFF
|
|
// and CJK Extension A: U+3400 to U+4DBF
|
|
if (r >= 0x4E00 && r <= 0x9FFF) || (r >= 0x3400 && r <= 0x4DBF) {
|
|
continue
|
|
}
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
|
|
// labelConstraint detects labels that contain non-ASCII characters except Chinese characters.
|
|
func labelConstraint(rc *models.RecordConfig) error {
|
|
if !isValidAliDNSString(rc.GetLabel()) {
|
|
return errors.New("label contains non-ASCII characters (only Chinese is allowed)")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// targetConstraint detects target values that contain non-ASCII characters except Chinese characters.
|
|
// This applies to CNAME, MX, NS, SRV targets.
|
|
func targetConstraint(rc *models.RecordConfig) error {
|
|
if !isValidAliDNSString(rc.GetTargetField()) {
|
|
return errors.New("target contains non-ASCII characters (only Chinese is allowed)")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// AuditRecords returns a list of errors corresponding to the records
|
|
// that aren't supported by this provider. If all records are
|
|
// supported, an empty list is returned.
|
|
func AuditRecords(records []*models.RecordConfig) []error {
|
|
// Note: We can't get domain version info here because AuditRecords
|
|
// is called without provider context. TTL validation will be done
|
|
// at the provider level in GetZoneRecordsCorrections.
|
|
a := rejectif.Auditor{}
|
|
|
|
a.Add("MX", rejectif.MxNull) // Last verified at 2025-12-03
|
|
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified at 2025-12-03
|
|
a.Add("TXT", rejectif.TxtLongerThan(512)) // Last verified at 2025-12-03: 511 bytes OK, 764 bytes failed
|
|
a.Add("TXT", rejectif.TxtHasDoubleQuotes) // Last verified at 2025-12-03: Alibaba strips quotes
|
|
a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified at 2025-12-03: Alibaba strips trailing spaces
|
|
a.Add("TXT", rejectif.TxtHasUnpairedBackslash) // Last verified at 2025-12-03: Alibaba mishandles odd backslashes
|
|
a.Add("*", labelConstraint) // Last verified at 2025-12-03: Alibaba only allows ASCII + Chinese, rejects other Unicode
|
|
a.Add("CNAME", targetConstraint) // Last verified at 2025-12-03: CNAME target must be ASCII or Chinese
|
|
a.Add("SRV", rejectif.SrvHasNullTarget) // Last verified at 2025-12-03: SRV target must not be null
|
|
a.Add("SRV", rejectif.SrvHasEmptyTarget) // Last verified at 2025-12-03: SRV target must not be empty
|
|
return a.Audit(records)
|
|
}
|