anthonyraymond/joal
1
1
Fork 0
mirror of https://github.com/anthonyraymond/joal.git synced 2024-11-10 09:02:31 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix some Intellij warnings

Browse source
This commit is contained in:
anthonyraymond 2017-05-29 22:42:30 +02:00
parent 699782111a
commit 1868d24a41
2 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/main/java/org/araymond/joal/core/ttorent/client/MockedTorrent.java
View file

@ -14,10 +14,9 @@ import java.security.NoSuchAlgorithmException;
/**
* Created by raymo on 23/01/2017.
*/
@SuppressWarnings("ClassWithOnlyPrivateConstructors")
public class MockedTorrent extends Torrent {
private final int pieceLength;
private final ByteBuffer piecesHashes;
private final Path path;
/**
@ -36,12 +35,12 @@ public class MockedTorrent extends Torrent {
this.path = path;
try {
this.pieceLength = this.decoded_info.get("piece length").getInt();
this.piecesHashes = ByteBuffer.wrap(this.decoded_info.get("pieces").getBytes());
// Torrent validity tests
final int pieceLength = this.decoded_info.get("piece length").getInt();
final ByteBuffer piecesHashes = ByteBuffer.wrap(this.decoded_info.get("pieces").getBytes());
if (this.piecesHashes.capacity() / Torrent.PIECE_HASH_SIZE * (long)this.pieceLength < this.getSize()) {
throw new IllegalArgumentException("Torrent size does not " +
"match the number of pieces and the piece size!");
if (piecesHashes.capacity() / Torrent.PIECE_HASH_SIZE * (long) pieceLength < this.getSize()) {
throw new IllegalArgumentException("Torrent size does not match the number of pieces and the piece size!");
}
} catch (final InvalidBEncodingException ex) {
throw new IllegalArgumentException("Error reading torrent meta-info fields!", ex);
@ -60,7 +59,6 @@ public class MockedTorrent extends Torrent {
@Override
public boolean equals(final Object o) {
// TODO : consider a better way to handle equals and hashcode
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
final MockedTorrent that = (MockedTorrent) o;

14
src/main/java/org/araymond/joal/core/ttorent/client/announce/Announcer.java
View file

@ -122,12 +122,14 @@ public class Announcer implements Runnable, AnnounceResponseListener {
@Override
public void handleDiscoveredPeers(final TorrentWithStats torrent, final List<Peer> peers) {
// TODO : ensure peers are leechers only, and not leechers + seeders
logger.info(
"Peers discovery for torrent {}: {} leechers",
torrent.getTorrent().getName(),
peers == null ? 0 : peers.size()
);
// FIXME : ensure peers are leechers only, and not leechers + seeders
if (logger.isInfoEnabled()) {
logger.info(
"Peers discovery for torrent {}: {} leechers",
torrent.getTorrent().getName(),
peers == null ? 0 : peers.size()
);
}
if (peers == null || peers.isEmpty()) {
this.eventListeners.forEach(listener -> listener.onNoMoreLeecherForTorrent(this, torrent));
}