From 189a6d68943bd737646d2c60ce61381a20f283d8 Mon Sep 17 00:00:00 2001 From: devezhao Date: Fri, 23 Aug 2019 14:02:54 +0800 Subject: [PATCH] code better --- .../server/business/trigger/impl/FieldAggregation.java | 9 +++++---- .../server/business/trigger/impl/SendNotification.java | 9 ++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/rebuild/server/business/trigger/impl/FieldAggregation.java b/src/main/java/com/rebuild/server/business/trigger/impl/FieldAggregation.java index 5cd99cdbf..26318977f 100644 --- a/src/main/java/com/rebuild/server/business/trigger/impl/FieldAggregation.java +++ b/src/main/java/com/rebuild/server/business/trigger/impl/FieldAggregation.java @@ -57,8 +57,8 @@ public class FieldAggregation implements TriggerAction { private static final int MAX_DEPTH = 5; // 当前操作用户可能对目标实体/记录无更新权限 - // 允许无权限更新目标实体 - private static final boolean ALLOW_NOPRIVILEGES_UPDATE = true; + // 此处标识是否允许无权限更新目标实体 + private static final boolean ALLOW_NOPERMISSION_UPDATE = true; final private ActionContext context; @@ -98,7 +98,7 @@ public class FieldAggregation implements TriggerAction { } // 如果当前用户对目标记录无修改权限 - if (!ALLOW_NOPRIVILEGES_UPDATE) { + if (!ALLOW_NOPERMISSION_UPDATE) { if (!Application.getSecurityManager().allowed( operatingContext.getOperator(), targetRecordId, BizzPermission.UPDATE)) { LOG.warn("No privileges to update record of target: " + this.targetRecordId); @@ -141,8 +141,9 @@ public class FieldAggregation implements TriggerAction { } if (targetRecord.getAvailableFieldIterator().hasNext()) { - if (ALLOW_NOPRIVILEGES_UPDATE) { + if (ALLOW_NOPERMISSION_UPDATE) { PrivilegesGuardInterceptor.setNoPrivilegesUpdateOnce(targetRecordId); + LOG.warn("Allow no permission updates : " + targetRecordId); } Application.getEntityService(targetEntity.getEntityCode()).update(targetRecord); CALL_CHAIN_DEPTH.set(depth + 1); diff --git a/src/main/java/com/rebuild/server/business/trigger/impl/SendNotification.java b/src/main/java/com/rebuild/server/business/trigger/impl/SendNotification.java index 44183ac2d..273ce5867 100644 --- a/src/main/java/com/rebuild/server/business/trigger/impl/SendNotification.java +++ b/src/main/java/com/rebuild/server/business/trigger/impl/SendNotification.java @@ -18,10 +18,7 @@ along with this program. If not, see . package com.rebuild.server.business.trigger.impl; -import java.util.ArrayList; -import java.util.List; -import java.util.Set; - +import cn.devezhao.persist4j.engine.ID; import com.alibaba.fastjson.JSONArray; import com.alibaba.fastjson.JSONObject; import com.rebuild.server.Application; @@ -34,7 +31,9 @@ import com.rebuild.server.service.bizz.UserHelper; import com.rebuild.server.service.notification.Message; import com.rebuild.server.service.notification.MessageBuilder; -import cn.devezhao.persist4j.engine.ID; +import java.util.ArrayList; +import java.util.List; +import java.util.Set; /** * @author devezhao zhaofang123@gmail.com