go-shiori/shiori
1
1
Fork 0
mirror of https://github.com/go-shiori/shiori.git synced 2024-09-20 06:56:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: temporary files not being correctly deleted (#969)

Browse source 
* fix: use os.Remove for tmpFile

* fix: delete double file remove

---------

Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
This commit is contained in:
Mario Rugiero 2024-08-28 06:51:19 -03:00 committed by GitHub
parent a4304bc19b
commit 2bcb890a64
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
internal/core/processing.go
View file

@ -166,7 +166,7 @@ func ProcessBookmark(deps *dependencies.Dependencies, req ProcessRequest) (book
if err != nil {
return book, false, fmt.Errorf("failed to create temp archive: %v", err)
}
defer deps.Domains.Storage.FS().Remove(tmpFile.Name())
defer os.Remove(tmpFile.Name())
archivalRequest := warc.ArchivalRequest{
URL: book.URL,
@ -178,7 +178,6 @@ func ProcessBookmark(deps *dependencies.Dependencies, req ProcessRequest) (book
err = warc.NewArchive(archivalRequest, tmpFile.Name())
if err != nil {
defer os.Remove(tmpFile.Name())
return book, false, fmt.Errorf("failed to create archive: %v", err)
}