go-shiori/shiori
1
1
Fork 0
mirror of https://github.com/go-shiori/shiori.git synced 2024-11-15 13:45:15 +08:00
Code Issues Projects Releases Packages Wiki Activity

Minor fix: no more closing channels

Browse source
This commit is contained in:
Radhi Fadlillah 2019-08-12 22:06:36 +07:00
parent bd9d4b1d0c
commit ba4c081710
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/warc/writer.go
View file

@ -66,7 +66,11 @@ func NewArchive(req ArchivalRequest, dstPath string) error {
ResourceMap: make(map[string]struct{}), ResourceMap: make(map[string]struct{}),
LogEnabled: req.LogEnabled, LogEnabled: req.LogEnabled,
} }
defer arc.Close()
// TODO: investigate whether the channel must be closed or not.
// At first, I thought the channels must be closed. Unfortunately, it leads to
// a panic when error message is accidentally sent after error channels closed.
// defer arc.Close()
// Process input depending on its type. // Process input depending on its type.
// If it's HTML, we need to extract the sub resources that used by it, e.g some CSS or JS files. // If it's HTML, we need to extract the sub resources that used by it, e.g some CSS or JS files.