mirror of
https://github.com/go-shiori/shiori.git
synced 2025-09-08 14:05:54 +08:00
* feat: Add SSO forward header * fix: Use domain layer * test: Some test * chore: Print new values when debugging * chore: Rename enabled envvar * fix: Wrongly parsing remote ip * fix: Always validate token. NPE on validateSession * fix: Dont overwrite token when sso * fix: Best effort to get ip. Parse as ip:port and then as ip * fix: Forgot to update handler version * fix: Forgot to commit changes * test: GetAccountByUsername * chore: Rename some variables * chore: return error from ssoAccount * refactor: Extract sso proxy auth to own middleware * fix: Dont panic if not sso account on legacy validate session * ci: gofmt --------- Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
214 lines
6.1 KiB
Go
214 lines
6.1 KiB
Go
package domains_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/go-shiori/shiori/internal/model"
|
|
"github.com/go-shiori/shiori/internal/testutil"
|
|
"github.com/sirupsen/logrus"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestAccountDomainsListAccounts(t *testing.T) {
|
|
logger := logrus.New()
|
|
_, deps := testutil.GetTestConfigurationAndDependencies(t, context.TODO(), logger)
|
|
|
|
t.Run("empty", func(t *testing.T) {
|
|
accounts, err := deps.Domains().Accounts().ListAccounts(context.Background())
|
|
require.NoError(t, err)
|
|
require.Empty(t, accounts)
|
|
})
|
|
|
|
t.Run("some accounts", func(t *testing.T) {
|
|
for i := 0; i < 3; i++ {
|
|
_, err := deps.Domains().Accounts().CreateAccount(context.TODO(), model.AccountDTO{
|
|
Username: fmt.Sprintf("user%d", i),
|
|
Password: fmt.Sprintf("password%d", i),
|
|
})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
accounts, err := deps.Domains().Accounts().ListAccounts(context.Background())
|
|
require.NoError(t, err)
|
|
require.Len(t, accounts, 3)
|
|
require.Equal(t, "", accounts[0].Password)
|
|
})
|
|
}
|
|
|
|
func TestAccountDomainsGetAccountByUsername(t *testing.T) {
|
|
logger := logrus.New()
|
|
_, deps := testutil.GetTestConfigurationAndDependencies(t, context.TODO(), logger)
|
|
|
|
t.Run("empty", func(t *testing.T) {
|
|
account, err := deps.Domains().Accounts().GetAccountByUsername(context.Background(), "")
|
|
require.Error(t, err)
|
|
require.Nil(t, account)
|
|
})
|
|
|
|
t.Run("account found", func(t *testing.T) {
|
|
_, err := deps.Domains().Accounts().CreateAccount(context.TODO(), model.AccountDTO{
|
|
Username: "user1",
|
|
Password: "password1",
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
account, err := deps.Domains().Accounts().GetAccountByUsername(context.Background(), "user1")
|
|
require.NoError(t, err)
|
|
require.NotNil(t, account)
|
|
require.Equal(t, "user1", account.Username)
|
|
})
|
|
}
|
|
|
|
func TestAccountDomainCreateAccount(t *testing.T) {
|
|
logger := logrus.New()
|
|
_, deps := testutil.GetTestConfigurationAndDependencies(t, context.TODO(), logger)
|
|
|
|
t.Run("create account", func(t *testing.T) {
|
|
acc, err := deps.Domains().Accounts().CreateAccount(context.TODO(), model.AccountDTO{
|
|
Username: "user",
|
|
Password: "password",
|
|
Owner: model.Ptr(true),
|
|
Config: &model.UserConfig{
|
|
Theme: "dark",
|
|
},
|
|
})
|
|
require.NoError(t, err)
|
|
require.NotZero(t, acc.ID)
|
|
require.Equal(t, "user", acc.Username)
|
|
require.Equal(t, "dark", acc.Config.Theme)
|
|
})
|
|
|
|
t.Run("create account with empty username", func(t *testing.T) {
|
|
_, err := deps.Domains().Accounts().CreateAccount(context.TODO(), model.AccountDTO{
|
|
Username: "",
|
|
Password: "password",
|
|
})
|
|
require.Error(t, err)
|
|
_, isValidationErr := err.(model.ValidationError)
|
|
require.True(t, isValidationErr)
|
|
})
|
|
|
|
t.Run("create account with empty password", func(t *testing.T) {
|
|
_, err := deps.Domains().Accounts().CreateAccount(context.TODO(), model.AccountDTO{
|
|
Username: "user",
|
|
Password: "",
|
|
})
|
|
require.Error(t, err)
|
|
_, isValidationErr := err.(model.ValidationError)
|
|
require.True(t, isValidationErr)
|
|
})
|
|
}
|
|
|
|
func TestAccountDomainUpdateAccount(t *testing.T) {
|
|
logger := logrus.New()
|
|
_, deps := testutil.GetTestConfigurationAndDependencies(t, context.TODO(), logger)
|
|
|
|
t.Run("update account", func(t *testing.T) {
|
|
acc, err := deps.Domains().Accounts().CreateAccount(context.TODO(), model.AccountDTO{
|
|
Username: "user",
|
|
Password: "password",
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
acc, err = deps.Domains().Accounts().UpdateAccount(context.TODO(), model.AccountDTO{
|
|
ID: acc.ID,
|
|
Username: "user2",
|
|
Password: "password2",
|
|
Owner: model.Ptr(true),
|
|
Config: &model.UserConfig{
|
|
Theme: "light",
|
|
},
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "user2", acc.Username)
|
|
require.Equal(t, "light", acc.Config.Theme)
|
|
})
|
|
|
|
t.Run("update non-existing account", func(t *testing.T) {
|
|
_, err := deps.Domains().Accounts().UpdateAccount(context.TODO(), model.AccountDTO{
|
|
ID: 999,
|
|
Username: "user",
|
|
Password: "password",
|
|
})
|
|
require.Error(t, err)
|
|
require.ErrorIs(t, err, model.ErrNotFound)
|
|
})
|
|
|
|
t.Run("try to update with no changes", func(t *testing.T) {
|
|
acc, err := deps.Domains().Accounts().CreateAccount(context.TODO(), model.AccountDTO{
|
|
Username: "user",
|
|
Password: "password",
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
_, err = deps.Domains().Accounts().UpdateAccount(context.TODO(), model.AccountDTO{
|
|
ID: acc.ID,
|
|
})
|
|
require.Error(t, err)
|
|
_, isValidationErr := err.(model.ValidationError)
|
|
require.True(t, isValidationErr)
|
|
})
|
|
}
|
|
|
|
func TestAccountDomainDeleteAccount(t *testing.T) {
|
|
logger := logrus.New()
|
|
_, deps := testutil.GetTestConfigurationAndDependencies(t, context.TODO(), logger)
|
|
|
|
t.Run("delete account", func(t *testing.T) {
|
|
acc, err := deps.Domains().Accounts().CreateAccount(context.TODO(), model.AccountDTO{
|
|
Username: "user",
|
|
Password: "password",
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
err = deps.Domains().Accounts().DeleteAccount(context.TODO(), int(acc.ID))
|
|
require.NoError(t, err)
|
|
|
|
accounts, err := deps.Domains().Accounts().ListAccounts(context.Background())
|
|
require.NoError(t, err)
|
|
require.Empty(t, accounts)
|
|
})
|
|
|
|
t.Run("delete non-existing account", func(t *testing.T) {
|
|
err := deps.Domains().Accounts().DeleteAccount(context.TODO(), 999)
|
|
require.Error(t, err)
|
|
require.ErrorIs(t, err, model.ErrNotFound)
|
|
})
|
|
|
|
t.Run("valid account", func(t *testing.T) {
|
|
account := testutil.GetValidAccount().ToDTO()
|
|
token, err := deps.Domains().Auth().CreateTokenForAccount(
|
|
&account,
|
|
time.Now().Add(time.Hour*1),
|
|
)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, token)
|
|
})
|
|
|
|
t.Run("nil account", func(t *testing.T) {
|
|
token, err := deps.Domains().Auth().CreateTokenForAccount(
|
|
nil,
|
|
time.Now().Add(time.Hour*1),
|
|
)
|
|
require.Error(t, err)
|
|
require.Empty(t, token)
|
|
})
|
|
|
|
t.Run("token expiration is valid", func(t *testing.T) {
|
|
ctx := context.TODO()
|
|
account := testutil.GetValidAccount().ToDTO()
|
|
expiration := time.Now().Add(time.Hour * 9)
|
|
token, err := deps.Domains().Auth().CreateTokenForAccount(
|
|
&account,
|
|
expiration,
|
|
)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, token)
|
|
tokenAccount, err := deps.Domains().Auth().CheckToken(ctx, token)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, tokenAccount)
|
|
})
|
|
}
|