mirror of
https://github.com/go-shiori/shiori.git
synced 2025-03-11 07:18:05 +08:00
5f1adc6c34
* fix(sqlite): avoid using dash in fts5 queries * test(db): get bookmarks and count with dash in keyword * test(db): common and ad-hoc sqlite test case
78 lines
2.2 KiB
Go
78 lines
2.2 KiB
Go
package database
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/go-shiori/shiori/internal/model"
|
|
"github.com/golang-migrate/migrate/v4"
|
|
"github.com/pkg/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
var sqliteDatabaseTestPath string
|
|
|
|
func init() {
|
|
sqliteDatabaseTestPath = filepath.Join(os.TempDir(), "shiori.db")
|
|
}
|
|
|
|
func sqliteTestDatabaseFactory(ctx context.Context) (DB, error) {
|
|
os.Remove(sqliteDatabaseTestPath)
|
|
|
|
db, err := OpenSQLiteDatabase(ctx, sqliteDatabaseTestPath)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if err := db.Migrate(); err != nil && !errors.Is(migrate.ErrNoChange, err) {
|
|
return nil, err
|
|
}
|
|
|
|
return db, nil
|
|
}
|
|
|
|
func TestSqliteDatabase(t *testing.T) {
|
|
testDatabase(t, sqliteTestDatabaseFactory)
|
|
testSqliteGetBookmarksWithDash(t)
|
|
}
|
|
|
|
// testSqliteGetBookmarksWithDash ad-hoc test for SQLite that checks that a match search against
|
|
// the FTS5 engine does not fail by using dashes, making sqlite think that we are trying to avoid
|
|
// matching a column name. This works in a fun way and it seems that it depends on the tokens
|
|
// already scanned by the database, since trying to match for `go-shiori` with no bookmarks or only
|
|
// the shiori bookmark does not fail, but it fails if we add any other bookmark to the database, hence
|
|
// this test.
|
|
func testSqliteGetBookmarksWithDash(t *testing.T) {
|
|
ctx := context.TODO()
|
|
|
|
db, err := sqliteTestDatabaseFactory(ctx)
|
|
assert.NoError(t, err)
|
|
|
|
book := model.Bookmark{
|
|
URL: "https://github.com/go-shiori/shiori",
|
|
Title: "shiori",
|
|
}
|
|
|
|
_, err = db.SaveBookmarks(ctx, true, book)
|
|
assert.NoError(t, err, "Save bookmarks must not fail")
|
|
|
|
book = model.Bookmark{
|
|
URL: "https://github.com/jamiehannaford/what-happens-when-k8s",
|
|
Title: "what-happens-when-k8s",
|
|
}
|
|
|
|
result, err := db.SaveBookmarks(ctx, true, book)
|
|
assert.NoError(t, err, "Save bookmarks must not fail")
|
|
savedBookmark := result[0]
|
|
|
|
results, err := db.GetBookmarks(ctx, GetBookmarksOptions{
|
|
Keyword: "what-happens-when",
|
|
})
|
|
|
|
assert.NoError(t, err, "Get bookmarks should not fail")
|
|
assert.Len(t, results, 1, "results should contain one item")
|
|
assert.Equal(t, savedBookmark.ID, results[0].ID, "bookmark should be the one saved")
|
|
|
|
}
|