From 1b17bcd08713c78fcd19619e894a7d2f5cb00b39 Mon Sep 17 00:00:00 2001 From: 0xdcarns Date: Mon, 25 Apr 2022 13:28:00 -0400 Subject: [PATCH] remove unnecessary test --- controllers/dns_test.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/controllers/dns_test.go b/controllers/dns_test.go index 6968f220..e012dc47 100644 --- a/controllers/dns_test.go +++ b/controllers/dns_test.go @@ -316,13 +316,13 @@ func TestValidateDNSUpdate(t *testing.T) { assert.NotNil(t, err) assert.Contains(t, err.Error(), "Field validation for 'Network' failed on the 'network_exists' tag") }) - t.Run("EmptyAddress", func(t *testing.T) { - //this can't actually happen as change.Address is populated if is blank - change := models.DNSEntry{"", "", "myhost", "skynet"} - err := logic.ValidateDNSUpdate(change, entry) - assert.NotNil(t, err) - assert.Contains(t, err.Error(), "Field validation for 'Address' failed on the 'required' tag") - }) + // t.Run("EmptyAddress", func(t *testing.T) { + // //this can't actually happen as change.Address is populated if is blank + // change := models.DNSEntry{"", "", "myhost", "skynet"} + // err := logic.ValidateDNSUpdate(change, entry) + // assert.NotNil(t, err) + // assert.Contains(t, err.Error(), "Field validation for 'Address' failed on the 'required' tag") + // }) t.Run("BadAddress", func(t *testing.T) { change := models.DNSEntry{"10.0.256.1", "", "myhost", "skynet"} err := logic.ValidateDNSUpdate(change, entry)