gravitl/netmaker
1
1
Fork 0
mirror of https://github.com/gravitl/netmaker.git synced 2024-11-10 17:48:25 +08:00
Code Issues Projects Releases Packages Wiki Activity

Revert: changing mechanics of loop (for ease of pr review)

Browse source 
cherry-pick the ineffective `err` assignment to make our following error check not useless
This commit is contained in:
kayos@tcp.direct 2022-12-06 20:26:46 -08:00
parent e878e4820a
commit 4c4cd6eb4d
No known key found for this signature in database
GPG key ID: 4B841471B4BEE979
1 changed files with 1 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
netclient/ncutils/netclientutils.go
View file

@ -162,29 +162,18 @@ func GetPublicIP(api string) (string, error) {
iplist = append([]string{api}, iplist...)
}
var bodies []*http.Response
defer func() {
for _, res := range bodies {
if res != nil {
_ = res.Body.Close()
}
}
}()
endpoint := ""
var err error
for _, ipserver := range iplist {
client := &http.Client{
Timeout: time.Second * 10,
}
var resp *http.Response
resp, err = client.Get(ipserver)
if err != nil {
continue
}
bodies = append(bodies, resp)
defer resp.Body.Close()
if resp.StatusCode == http.StatusOK {
var bodyBytes []byte
bodyBytes, err = io.ReadAll(resp.Body)