From 63708e6e360c6f1a9367f99f918da68071d6ca07 Mon Sep 17 00:00:00 2001 From: Abhishek Kondur Date: Wed, 13 Jul 2022 14:53:37 +0400 Subject: [PATCH] GRA-414: added additional logs for acl controllers --- controllers/network.go | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/controllers/network.go b/controllers/network.go index bf21b017..fa7f5b96 100644 --- a/controllers/network.go +++ b/controllers/network.go @@ -273,12 +273,22 @@ func updateNetworkACL(w http.ResponseWriter, r *http.Request) { var networkACLChange acls.ACLContainer networkACLChange, err := networkACLChange.Get(acls.ContainerID(netname)) if err != nil { + logger.Log(0, r.Header.Get("user"), + fmt.Sprintf("failed to fetch ACLs for network [%s]: %v", netname, err)) returnErrorResponse(w, r, formatError(err, "internal")) return } - _ = json.NewDecoder(r.Body).Decode(&networkACLChange) + err = json.NewDecoder(r.Body).Decode(&networkACLChange) + if err != nil { + logger.Log(0, r.Header.Get("user"), "error decoding request body: ", + err.Error()) + returnErrorResponse(w, r, formatError(err, "badrequest")) + return + } newNetACL, err := networkACLChange.Save(acls.ContainerID(netname)) if err != nil { + logger.Log(0, r.Header.Get("user"), + fmt.Sprintf("failed to update ACLs for network [%s]: %v", netname, err)) returnErrorResponse(w, r, formatError(err, "badrequest")) return } @@ -310,6 +320,8 @@ func getNetworkACL(w http.ResponseWriter, r *http.Request) { var networkACL acls.ACLContainer networkACL, err := networkACL.Get(acls.ContainerID(netname)) if err != nil { + logger.Log(0, r.Header.Get("user"), + fmt.Sprintf("failed to fetch ACLs for network [%s]: %v", netname, err)) returnErrorResponse(w, r, formatError(err, "internal")) return }