From 8a0d688867c079176bbcdbd3e6a6354f52e74d38 Mon Sep 17 00:00:00 2001
From: Matthew R Kasun <mkasun@nusak.ca>
Date: Thu, 9 Sep 2021 13:59:43 -0400
Subject: [PATCH] fixed node tests

---
 controllers/nodeHttpController_test.go | 313 +++++++++++--------------
 1 file changed, 139 insertions(+), 174 deletions(-)

diff --git a/controllers/nodeHttpController_test.go b/controllers/nodeHttpController_test.go
index f28ece07..99260b30 100644
--- a/controllers/nodeHttpController_test.go
+++ b/controllers/nodeHttpController_test.go
@@ -1,183 +1,148 @@
 package controller
 
 import (
+	"testing"
+
+	"github.com/gravitl/netmaker/database"
 	"github.com/gravitl/netmaker/models"
+	"github.com/stretchr/testify/assert"
 )
 
-//func TestCheckIn(t *testing.T) {
-//	deleteNet(t)
-//	createNet()
-//	node := createTestNode(t)
-//	time.Sleep(time.Second * 1)
-//	t.Run("BadNet", func(t *testing.T) {
-//		resp, err := CheckIn("badnet", node.MacAddress)
-//		assert.NotNil(t, err)
-//		assert.Equal(t, models.Node{}, resp)
-//		assert.Equal(t, "mongo: no documents in result", err.Error())
-//	})
-//	t.Run("BadMac", func(t *testing.T) {
-//		resp, err := CheckIn("skynet", "01:02:03")
-//		assert.NotNil(t, err)
-//		assert.Equal(t, models.Node{}, resp)
-//		assert.Equal(t, "mongo: no documents in result", err.Error())
-//	})
-//	t.Run("Success", func(t *testing.T) {
-//		resp, err := CheckIn("skynet", node.MacAddress)
-//		assert.Nil(t, err)
-//		assert.Greater(t, resp.LastCheckIn, node.LastCheckIn)
-//	})
-//}
-//func TestCreateEgressGateway(t *testing.T) {
-//	var gateway models.EgressGatewayRequest
-//	gateway.Interface = "eth0"
-//	gateway.Ranges = []string{"10.100.100.0/24"}
-//	deleteNet(t)
-//	createNet()
-//	t.Run("NoNodes", func(t *testing.T) {
-//		node, err := CreateEgressGateway(gateway)
-//		assert.NotNil(t, err)
-//		assert.Equal(t, models.Node{}, node)
-//		assert.Equal(t, "mongo: no documents in result", err.Error())
-//	})
-//	t.Run("Success", func(t *testing.T) {
-//		testnode := createTestNode(t)
-//		gateway.NetID = "skynet"
-//		gateway.NodeID = testnode.MacAddress
-//
-//		node, err := CreateEgressGateway(gateway)
-//		assert.Nil(t, err)
-//		assert.Equal(t, true, node.IsEgressGateway)
-//		assert.Equal(t, "10.100.100.0/24", node.EgressGatewayRange)
-//	})
-//
-//}
-//func TestDeleteEgressGateway(t *testing.T) {
-//	var gateway models.EgressGatewayRequest
-//	deleteNet(t)
-//	createNet()
-//	createTestNode(t)
-//	testnode := createTestNode(t)
-//	gateway.Interface = "eth0"
-//	gateway.Ranges = []string{"10.100.100.0/24"}
-//	gateway.NetID = "skynet"
-//	gateway.NodeID = testnode.MacAddress
-//	t.Run("Success", func(t *testing.T) {
-//		node, err := CreateEgressGateway(gateway)
-//		assert.Nil(t, err)
-//		assert.Equal(t, true, node.IsEgressGateway)
-//		assert.Equal(t, []string{"10.100.100.0/24"}, node.EgressGatewayRanges)
-//		node, err = DeleteEgressGateway(gateway.NetID, gateway.NodeID)
-//		assert.Nil(t, err)
-//		assert.Equal(t, false, node.IsEgressGateway)
-//		assert.Equal(t, "", node.EgressGatewayRanges)
-//		assert.Equal(t, "", node.PostUp)
-//		assert.Equal(t, "", node.PostDown)
-//	})
-//	t.Run("NotGateway", func(t *testing.T) {
-//		node, err := DeleteEgressGateway(gateway.NetID, gateway.NodeID)
-//		assert.Nil(t, err)
-//		assert.Equal(t, false, node.IsEgressGateway)
-//		assert.Equal(t, "", node.EgressGatewayRanges)
-//		assert.Equal(t, "", node.PostUp)
-//		assert.Equal(t, "", node.PostDown)
-//	})
-//	t.Run("BadNode", func(t *testing.T) {
-//		node, err := DeleteEgressGateway(gateway.NetID, "01:02:03")
-//		assert.NotNil(t, err)
-//		assert.Equal(t, "mongo: no documents in result", err.Error())
-//		assert.Equal(t, models.Node{}, node)
-//	})
-//	t.Run("BadNet", func(t *testing.T) {
-//		node, err := DeleteEgressGateway("badnet", gateway.NodeID)
-//		assert.NotNil(t, err)
-//		assert.Equal(t, "mongo: no documents in result", err.Error())
-//		assert.Equal(t, models.Node{}, node)
-//	})
-//
-//}
-//func TestGetLastModified(t *testing.T) {
-//	deleteNet(t)
-//	createNet()
-//	createTestNode(t)
-//	t.Run("BadNet", func(t *testing.T) {
-//		network, err := GetLastModified("badnet")
-//		assert.NotNil(t, err)
-//		assert.Equal(t, models.Network{}, network)
-//		assert.Equal(t, "mongo: no documents in result", err.Error())
-//	})
-//	t.Run("Success", func(t *testing.T) {
-//		network, err := GetLastModified("skynet")
-//		assert.Nil(t, err)
-//		assert.NotEqual(t, models.Network{}, network)
-//	})
-//}
-//func TestGetNetworkNodes(t *testing.T) {
-//	deleteNet(t)
-//	createNet()
-//	t.Run("BadNet", func(t *testing.T) {
-//		node, err := GetNetworkNodes("badnet")
-//		assert.Nil(t, err)
-//		assert.Equal(t, []models.Node(nil), node)
-//		//assert.Equal(t, "mongo: no documents in result", err.Error())
-//	})
-//	t.Run("NoNodes", func(t *testing.T) {
-//		node, err := GetNetworkNodes("skynet")
-//		assert.Nil(t, err)
-//		assert.Equal(t, []models.Node(nil), node)
-//	})
-//	t.Run("Success", func(t *testing.T) {
-//		createTestNode(t)
-//		node, err := GetNetworkNodes("skynet")
-//		assert.Nil(t, err)
-//		assert.NotEqual(t, []models.Node(nil), node)
-//	})
-//
-//}
-//func TestUncordonNode(t *testing.T) {
-//	deleteNet(t)
-//	createNet()
-//	node := createTestNode(t)
-//	t.Run("BadNet", func(t *testing.T) {
-//		resp, err := UncordonNode("badnet", node.MacAddress)
-//		assert.NotNil(t, err)
-//		assert.Equal(t, models.Node{}, resp)
-//		assert.Equal(t, "mongo: no documents in result", err.Error())
-//	})
-//	t.Run("BadMac", func(t *testing.T) {
-//		resp, err := UncordonNode("skynet", "01:02:03")
-//		assert.NotNil(t, err)
-//		assert.Equal(t, models.Node{}, resp)
-//		assert.Equal(t, "mongo: no documents in result", err.Error())
-//	})
-//	t.Run("Success", func(t *testing.T) {
-//		resp, err := CheckIn("skynet", node.MacAddress)
-//		assert.Nil(t, err)
-//		assert.Equal(t, false, resp.IsPending)
-//	})
-//
-//}
-//func TestValidateEgressGateway(t *testing.T) {
-//	var gateway models.EgressGatewayRequest
-//	t.Run("EmptyRange", func(t *testing.T) {
-//		gateway.Interface = "eth0"
-//		gateway.Ranges = []string{}
-//		err := ValidateEgressGateway(gateway)
-//		assert.NotNil(t, err)
-//		assert.Equal(t, "IP Range Not Valid", err.Error())
-//	})
-//	t.Run("EmptyInterface", func(t *testing.T) {
-//		gateway.Interface = ""
-//		err := ValidateEgressGateway(gateway)
-//		assert.NotNil(t, err)
-//		assert.Equal(t, "Interface cannot be empty", err.Error())
-//	})
-//	t.Run("Success", func(t *testing.T) {
-//		gateway.Interface = "eth0"
-//		gateway.Ranges = []string{"10.100.100.0/24"}
-//		err := ValidateEgressGateway(gateway)
-//		assert.Nil(t, err)
-//	})
-//}
+func TestCreateEgressGateway(t *testing.T) {
+	var gateway models.EgressGatewayRequest
+	gateway.Interface = "eth0"
+	gateway.Ranges = []string{"10.100.100.0/24"}
+	database.InitializeDatabase()
+	deleteAllNetworks()
+	createNet()
+	t.Run("NoNodes", func(t *testing.T) {
+		node, err := CreateEgressGateway(gateway)
+		assert.Equal(t, models.Node{}, node)
+		assert.EqualError(t, err, "unable to get record key")
+	})
+	t.Run("Success", func(t *testing.T) {
+		testnode := createTestNode()
+		gateway.NetID = "skynet"
+		gateway.NodeID = testnode.MacAddress
+
+		node, err := CreateEgressGateway(gateway)
+		assert.Nil(t, err)
+		assert.Equal(t, "yes", node.IsEgressGateway)
+		assert.Equal(t, gateway.Ranges, node.EgressGatewayRanges)
+	})
+
+}
+func TestDeleteEgressGateway(t *testing.T) {
+	var gateway models.EgressGatewayRequest
+	database.InitializeDatabase()
+	deleteAllNetworks()
+	createNet()
+	createTestNode()
+	testnode := createTestNode()
+	gateway.Interface = "eth0"
+	gateway.Ranges = []string{"10.100.100.0/24"}
+	gateway.NetID = "skynet"
+	gateway.NodeID = testnode.MacAddress
+	t.Run("Success", func(t *testing.T) {
+		node, err := CreateEgressGateway(gateway)
+		assert.Nil(t, err)
+		assert.Equal(t, "yes", node.IsEgressGateway)
+		assert.Equal(t, []string{"10.100.100.0/24"}, node.EgressGatewayRanges)
+		node, err = DeleteEgressGateway(gateway.NetID, gateway.NodeID)
+		assert.Nil(t, err)
+		assert.Equal(t, "no", node.IsEgressGateway)
+		assert.Equal(t, []string([]string{}), node.EgressGatewayRanges)
+		assert.Equal(t, "", node.PostUp)
+		assert.Equal(t, "", node.PostDown)
+	})
+	t.Run("NotGateway", func(t *testing.T) {
+		node, err := DeleteEgressGateway(gateway.NetID, gateway.NodeID)
+		assert.Nil(t, err)
+		assert.Equal(t, "no", node.IsEgressGateway)
+		assert.Equal(t, []string([]string{}), node.EgressGatewayRanges)
+		assert.Equal(t, "", node.PostUp)
+		assert.Equal(t, "", node.PostDown)
+	})
+	t.Run("BadNode", func(t *testing.T) {
+		node, err := DeleteEgressGateway(gateway.NetID, "01:02:03")
+		assert.EqualError(t, err, "no result found")
+		assert.Equal(t, models.Node{}, node)
+	})
+	t.Run("BadNet", func(t *testing.T) {
+		node, err := DeleteEgressGateway("badnet", gateway.NodeID)
+		assert.EqualError(t, err, "no result found")
+		assert.Equal(t, models.Node{}, node)
+	})
+
+}
+
+func TestGetNetworkNodes(t *testing.T) {
+	database.InitializeDatabase()
+	deleteAllNetworks()
+	createNet()
+	t.Run("BadNet", func(t *testing.T) {
+		node, err := GetNetworkNodes("badnet")
+		assert.Nil(t, err)
+		assert.Equal(t, []models.Node{}, node)
+		//assert.Equal(t, "mongo: no documents in result", err.Error())
+	})
+	t.Run("NoNodes", func(t *testing.T) {
+		node, err := GetNetworkNodes("skynet")
+		assert.Nil(t, err)
+		assert.Equal(t, []models.Node{}, node)
+	})
+	t.Run("Success", func(t *testing.T) {
+		createTestNode()
+		node, err := GetNetworkNodes("skynet")
+		assert.Nil(t, err)
+		assert.NotEqual(t, []models.Node(nil), node)
+	})
+
+}
+func TestUncordonNode(t *testing.T) {
+	database.InitializeDatabase()
+	deleteAllNetworks()
+	createNet()
+	node := createTestNode()
+	t.Run("BadNet", func(t *testing.T) {
+		resp, err := UncordonNode("badnet", node.MacAddress)
+		assert.Equal(t, models.Node{}, resp)
+		assert.EqualError(t, err, "no result found")
+	})
+	t.Run("BadMac", func(t *testing.T) {
+		resp, err := UncordonNode("skynet", "01:02:03")
+		assert.Equal(t, models.Node{}, resp)
+		assert.EqualError(t, err, "no result found")
+	})
+	t.Run("Success", func(t *testing.T) {
+		resp, err := UncordonNode("skynet", node.MacAddress)
+		assert.Nil(t, err)
+		assert.Equal(t, "no", resp.IsPending)
+	})
+
+}
+func TestValidateEgressGateway(t *testing.T) {
+	var gateway models.EgressGatewayRequest
+	t.Run("EmptyRange", func(t *testing.T) {
+		gateway.Interface = "eth0"
+		gateway.Ranges = []string{}
+		err := ValidateEgressGateway(gateway)
+		assert.EqualError(t, err, "IP Ranges Cannot Be Empty")
+	})
+	t.Run("EmptyInterface", func(t *testing.T) {
+		gateway.Interface = ""
+		err := ValidateEgressGateway(gateway)
+		assert.NotNil(t, err)
+		assert.Equal(t, "Interface cannot be empty", err.Error())
+	})
+	t.Run("Success", func(t *testing.T) {
+		gateway.Interface = "eth0"
+		gateway.Ranges = []string{"10.100.100.0/24"}
+		err := ValidateEgressGateway(gateway)
+		assert.Nil(t, err)
+	})
+}
+
 //
 ////func TestUpdateNode(t *testing.T) {
 ////}