gravitl/netmaker
1
1
Fork 0
mirror of https://github.com/gravitl/netmaker.git synced 2025-12-16 07:38:17 +08:00
Code Issues Projects Releases Packages Wiki Activity

NetClientUtils: Avoid using defer in a for loop, this causes resource leaks.

Browse source
This commit is contained in:
kayos@tcp.direct 2023-02-16 02:09:58 -08:00
parent 92dbfa52a5
commit a15650d3e0
No known key found for this signature in database
GPG key ID: 4B841471B4BEE979
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
netclient/ncutils/netclientutils.go
View file

@ -166,13 +166,16 @@ func GetPublicIP(api string) (string, error) {
if err != nil { if err != nil {
continue continue
} }
defer resp.Body.Close()
if resp.StatusCode == http.StatusOK { if resp.StatusCode == http.StatusOK {
var bodyBytes []byte var bodyBytes []byte
bodyBytes, err = io.ReadAll(resp.Body) bodyBytes, err = io.ReadAll(resp.Body)
if err != nil { if err != nil {
if resp.Body != nil {
_ = resp.Body.Close()
}
continue continue
} }
_ = resp.Body.Close()
endpoint = string(bodyBytes) endpoint = string(bodyBytes)
break break
} }