gravitl/netmaker
1
1
Fork 0
mirror of https://github.com/gravitl/netmaker.git synced 2025-10-11 14:26:33 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(NET-760): check for private network range (#2722)

Browse source
This commit is contained in:
Aceix 2023-12-13 10:02:57 +00:00 • committed by GitHub
parent 643950f9eb
commit c8ae70bd69
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 35 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
controllers/network.go
View file

@ -4,6 +4,7 @@ import (
"encoding/json" "encoding/json"
"errors" "errors"
"fmt" "fmt"
"net"
"net/http" "net/http"
"strings" "strings"
@ -246,6 +247,40 @@ func createNetwork(w http.ResponseWriter, r *http.Request) {
return return
} }
// validate address ranges: must be private
if network.AddressRange != "" {
_, ipNet, err := net.ParseCIDR(network.AddressRange)
if err != nil {
logger.Log(0, r.Header.Get("user"), "failed to create network: ",
err.Error())
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
return
}
if !ipNet.IP.IsPrivate() {
err := errors.New("address range must be private")
logger.Log(0, r.Header.Get("user"), "failed to create network: ",
err.Error())
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
return
}
}
if network.AddressRange6 != "" {
_, ipNet, err := net.ParseCIDR(network.AddressRange6)
if err != nil {
logger.Log(0, r.Header.Get("user"), "failed to create network: ",
err.Error())
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
return
}
if !ipNet.IP.IsPrivate() {
err := errors.New("address range must be private")
logger.Log(0, r.Header.Get("user"), "failed to create network: ",
err.Error())
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
return
}
}
network, err = logic.CreateNetwork(network) network, err = logic.CreateNetwork(network)
if err != nil { if err != nil {
logger.Log(0, r.Header.Get("user"), "failed to create network: ", logger.Log(0, r.Header.Get("user"), "failed to create network: ",