From e7427c89cc38b29c16836828b137ba6aaada3150 Mon Sep 17 00:00:00 2001 From: "Matthew R. Kasun" Date: Thu, 22 Dec 2022 09:48:09 -0500 Subject: [PATCH] refactor workflow --- .github/workflows/publish-docker.yml | 18 +++++++++--------- Dockerfile | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml index f5d9082f..16251e84 100644 --- a/.github/workflows/publish-docker.yml +++ b/.github/workflows/publish-docker.yml @@ -33,12 +33,12 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v2 - - - name: Login to DockerHub - uses: docker/login-action@v2 - with: - username: ${{ secrets.DOCKERHUB_USERNAME }} - password: ${{ secrets.DOCKERHUB_TOKEN }} + #- + # name: Login to DockerHub + # uses: docker/login-action@v2 + # with: + # username: ${{ secrets.DOCKERHUB_USERNAME }} + # password: ${{ secrets.DOCKERHUB_TOKEN }} - name: Build and push uses: docker/build-push-action@v3 @@ -47,7 +47,7 @@ jobs: platforms: linux/amd64, linux/arm64, linux/arm/v7 push: true tags: ${{ github.repository }}:${{ env.TAG }}, ${{ github.repository }}:latest - build-args: version=${{ env.TAG }}, tags="-tags=ce" + build-args: version=${{ env.TAG }}, tags=ce docker-ee: runs-on: ubuntu-latest @@ -56,7 +56,7 @@ jobs: name: Set tag run: | if [[ -n "${{ github.event.inputs.tag }}" ]]; then - docker/build-push-action@v3.tag }} + TAG=${{ github.event.inputs.tag }} elif [[ "${{ github.ref_name }}" == 'master' ]]; then TAG="latest" else @@ -86,4 +86,4 @@ jobs: platforms: linux/amd64, linux/arm64, linux/arm/v7 push: true tags: ${{ github.repository }}:${{ env.TAG }}-ee - build-args: version=${{ env.TAG }}, tags="-tags=ee" + build-args: version=${{ env.TAG }}, tags=ee diff --git a/Dockerfile b/Dockerfile index 11ced429..61f02e95 100644 --- a/Dockerfile +++ b/Dockerfile @@ -7,7 +7,7 @@ COPY . . ENV GO111MODULE=auto RUN apk add git -RUN GOOS=linux CGO_ENABLED=1 go build -ldflags="-s -X 'main.version=${version}'" ${tags} . +RUN GOOS=linux CGO_ENABLED=1 go build -ldflags="-s -X 'main.version=${version}'" -tags ${tags} . # RUN go build -tags=ee . -o netmaker main.go FROM alpine:3.16.2