chore(NET-1245): remove check for private network address (#2934)

This commit is contained in:
Aceix 2024-05-14 14:24:00 +00:00 committed by GitHub
parent 4a355ee9f3
commit faf50c8c3d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -442,36 +442,22 @@ func createNetwork(w http.ResponseWriter, r *http.Request) {
// validate address ranges: must be private
if network.AddressRange != "" {
_, ipNet, err := net.ParseCIDR(network.AddressRange)
_, _, err := net.ParseCIDR(network.AddressRange)
if err != nil {
logger.Log(0, r.Header.Get("user"), "failed to create network: ",
err.Error())
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
return
}
if !ipNet.IP.IsPrivate() {
err := errors.New("address range must be private")
logger.Log(0, r.Header.Get("user"), "failed to create network: ",
err.Error())
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
return
}
}
if network.AddressRange6 != "" {
_, ipNet, err := net.ParseCIDR(network.AddressRange6)
_, _, err := net.ParseCIDR(network.AddressRange6)
if err != nil {
logger.Log(0, r.Header.Get("user"), "failed to create network: ",
err.Error())
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
return
}
if !ipNet.IP.IsPrivate() {
err := errors.New("address range must be private")
logger.Log(0, r.Header.Get("user"), "failed to create network: ",
err.Error())
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
return
}
}
network, err = logic.CreateNetwork(network)