mirror of
https://github.com/gravitl/netmaker.git
synced 2025-11-09 16:21:01 +08:00
- Avoid referencing conditions we know are false/true - Avoid using name of imported package as variable - Avoid broken (see list item 1) if else statement in `ipservice.go` by refactoring to switch statement - When assigning a pointer value to a variable along with an error, check that error before referencing that pointer. Thus avoiding de-referencing a nil and causing a panic. *** This item is the most important *** - Standard gofmt package sorting + linting; This includes fixing comment starts for go doc - Explicit non-handling of unhandled errors where appropriate (assigning errs to _ to reduce linter screaming) - Export ErrExpired in `netcache` package so that we can properly reference it using `errors.Is` instead of using `strings.Contains` against an `error.Error()` value |
||
|---|---|---|
| .. | ||
| config | ||
| admincreate.sh | ||
| api_test.go.bak | ||
| gatewaycreate.sh | ||
| groupcreate.sh | ||
| groupscreate.sh | ||
| keycreate.sh | ||
| main.go | ||
| network_test.go.bak | ||
| node_test.go.bak | ||
| nodecreate.sh | ||
| nodescreate.sh | ||
| test.script | ||
| user_test.go.bak | ||