mirror of
https://github.com/gravitl/netmaker.git
synced 2024-11-10 17:48:25 +08:00
719e0c254d
* add superadmin role, apis to create superadmin user * apis to attach and remove user from remote access gateways * add api to list user's remote client has gateway clients * remove code related user groups * remove networks and groups from user model * refactor user CRUD operations * fix network permission test * add superadmin to authorize func * remove user network and groups from cli * api to transfer superadmin role * add api to list users on a ingress gw * restrict user access to resources on server * deny request from remote access client if extclient is already created * fix user tests * fix static checks * fix static checks * add limits to extclient create handler * set username to superadmin on if masterkey is used * allow creation of extclients using masterkey * add migration func to assign superadmin role for existing admin user * check for superadmin on migration if users are present * allowe masterkey to extcleint apis * check ownerid * format error, on jwt token verification failure return unauthorized rather than forbidden * user update fix * move user remote functionality to ee * fix update user api * security patch * initalise ee user handlers * allow user to use master key to update any user * use slog * fix auth user test * table headers * remove user role, it's covered in middleware * setuser defaults fix
241 lines
6 KiB
Go
241 lines
6 KiB
Go
package controller
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/gravitl/netmaker/database"
|
|
"github.com/gravitl/netmaker/logger"
|
|
"github.com/gravitl/netmaker/logic"
|
|
"github.com/gravitl/netmaker/models"
|
|
"github.com/stretchr/testify/assert"
|
|
"golang.zx2c4.com/wireguard/wgctrl/wgtypes"
|
|
)
|
|
|
|
type NetworkValidationTestCase struct {
|
|
testname string
|
|
network models.Network
|
|
errMessage string
|
|
}
|
|
|
|
var netHost models.Host
|
|
|
|
func TestMain(m *testing.M) {
|
|
database.InitializeDatabase()
|
|
defer database.CloseDB()
|
|
logic.CreateSuperAdmin(&models.User{
|
|
UserName: "admin",
|
|
Password: "password",
|
|
IsAdmin: true,
|
|
})
|
|
peerUpdate := make(chan *models.Node)
|
|
go logic.ManageZombies(context.Background(), peerUpdate)
|
|
go func() {
|
|
for update := range peerUpdate {
|
|
//do nothing
|
|
logger.Log(3, "received node update", update.Action)
|
|
}
|
|
}()
|
|
os.Exit(m.Run())
|
|
|
|
}
|
|
|
|
func TestCreateNetwork(t *testing.T) {
|
|
deleteAllNetworks()
|
|
|
|
var network models.Network
|
|
network.NetID = "skynet"
|
|
network.AddressRange = "10.0.0.1/24"
|
|
// if tests break - check here (removed displayname)
|
|
//network.DisplayName = "mynetwork"
|
|
|
|
_, err := logic.CreateNetwork(network)
|
|
assert.Nil(t, err)
|
|
}
|
|
func TestGetNetwork(t *testing.T) {
|
|
createNet()
|
|
|
|
t.Run("GetExistingNetwork", func(t *testing.T) {
|
|
network, err := logic.GetNetwork("skynet")
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, "skynet", network.NetID)
|
|
})
|
|
t.Run("GetNonExistantNetwork", func(t *testing.T) {
|
|
network, err := logic.GetNetwork("doesnotexist")
|
|
assert.EqualError(t, err, "no result found")
|
|
assert.Equal(t, "", network.NetID)
|
|
})
|
|
}
|
|
|
|
func TestDeleteNetwork(t *testing.T) {
|
|
createNet()
|
|
//create nodes
|
|
t.Run("NetworkwithNodes", func(t *testing.T) {
|
|
})
|
|
t.Run("DeleteExistingNetwork", func(t *testing.T) {
|
|
err := logic.DeleteNetwork("skynet")
|
|
assert.Nil(t, err)
|
|
})
|
|
t.Run("NonExistentNetwork", func(t *testing.T) {
|
|
err := logic.DeleteNetwork("skynet")
|
|
assert.Nil(t, err)
|
|
})
|
|
}
|
|
|
|
func TestSecurityCheck(t *testing.T) {
|
|
//these seem to work but not sure it the tests are really testing the functionality
|
|
|
|
os.Setenv("MASTER_KEY", "secretkey")
|
|
t.Run("NoNetwork", func(t *testing.T) {
|
|
username, err := logic.UserPermissions(false, "Bearer secretkey")
|
|
assert.Nil(t, err)
|
|
t.Log(username)
|
|
})
|
|
|
|
t.Run("BadToken", func(t *testing.T) {
|
|
username, err := logic.UserPermissions(false, "Bearer badkey")
|
|
assert.NotNil(t, err)
|
|
t.Log(err)
|
|
t.Log(username)
|
|
})
|
|
}
|
|
|
|
func TestValidateNetwork(t *testing.T) {
|
|
//t.Skip()
|
|
//This functions is not called by anyone
|
|
//it panics as validation function 'display_name_valid' is not defined
|
|
//yes := true
|
|
//no := false
|
|
//deleteNet(t)
|
|
|
|
//DeleteNetworks
|
|
cases := []NetworkValidationTestCase{
|
|
{
|
|
testname: "InvalidAddress",
|
|
network: models.Network{
|
|
NetID: "skynet",
|
|
AddressRange: "10.0.0.256",
|
|
},
|
|
errMessage: "Field validation for 'AddressRange' failed on the 'cidrv4' tag",
|
|
},
|
|
{
|
|
testname: "InvalidAddress6",
|
|
network: models.Network{
|
|
NetID: "skynet1",
|
|
AddressRange6: "2607::ffff/130",
|
|
},
|
|
errMessage: "Field validation for 'AddressRange6' failed on the 'cidrv6' tag",
|
|
},
|
|
{
|
|
testname: "InvalidNetID",
|
|
network: models.Network{
|
|
NetID: "with spaces",
|
|
},
|
|
errMessage: "Field validation for 'NetID' failed on the 'netid_valid' tag",
|
|
},
|
|
{
|
|
testname: "NetIDTooLong",
|
|
network: models.Network{
|
|
NetID: "LongNetIDNameForMaxCharactersTest",
|
|
},
|
|
errMessage: "Field validation for 'NetID' failed on the 'max' tag",
|
|
},
|
|
{
|
|
testname: "ListenPortTooLow",
|
|
network: models.Network{
|
|
NetID: "skynet",
|
|
DefaultListenPort: 1023,
|
|
},
|
|
errMessage: "Field validation for 'DefaultListenPort' failed on the 'min' tag",
|
|
},
|
|
{
|
|
testname: "ListenPortTooHigh",
|
|
network: models.Network{
|
|
NetID: "skynet",
|
|
DefaultListenPort: 65536,
|
|
},
|
|
errMessage: "Field validation for 'DefaultListenPort' failed on the 'max' tag",
|
|
},
|
|
{
|
|
testname: "KeepAliveTooBig",
|
|
network: models.Network{
|
|
NetID: "skynet",
|
|
DefaultKeepalive: 1010,
|
|
},
|
|
errMessage: "Field validation for 'DefaultKeepalive' failed on the 'max' tag",
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.testname, func(t *testing.T) {
|
|
t.Log(tc.testname)
|
|
network := models.Network(tc.network)
|
|
network.SetDefaults()
|
|
err := logic.ValidateNetwork(&network, false)
|
|
assert.NotNil(t, err)
|
|
assert.Contains(t, err.Error(), tc.errMessage) // test passes if err.Error() contains the expected errMessage.
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestIpv6Network(t *testing.T) {
|
|
//these seem to work but not sure it the tests are really testing the functionality
|
|
|
|
os.Setenv("MASTER_KEY", "secretkey")
|
|
deleteAllNetworks()
|
|
createNet()
|
|
createNetDualStack()
|
|
network, err := logic.GetNetwork("skynet6")
|
|
t.Run("Test Network Create IPv6", func(t *testing.T) {
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, network.AddressRange6, "fde6:be04:fa5e:d076::/64")
|
|
})
|
|
node1 := createNodeWithParams("skynet6", "")
|
|
createNetHost()
|
|
nodeErr := logic.AssociateNodeToHost(node1, &netHost)
|
|
t.Run("Test node on network IPv6", func(t *testing.T) {
|
|
assert.Nil(t, nodeErr)
|
|
assert.Equal(t, "fde6:be04:fa5e:d076::1", node1.Address6.IP.String())
|
|
})
|
|
}
|
|
|
|
func deleteAllNetworks() {
|
|
deleteAllNodes()
|
|
database.DeleteAllRecords(database.NETWORKS_TABLE_NAME)
|
|
}
|
|
|
|
func createNet() {
|
|
var network models.Network
|
|
network.NetID = "skynet"
|
|
network.AddressRange = "10.0.0.1/24"
|
|
_, err := logic.GetNetwork("skynet")
|
|
if err != nil {
|
|
logic.CreateNetwork(network)
|
|
}
|
|
}
|
|
|
|
func createNetDualStack() {
|
|
var network models.Network
|
|
network.NetID = "skynet6"
|
|
network.AddressRange = "10.1.2.0/24"
|
|
network.AddressRange6 = "fde6:be04:fa5e:d076::/64"
|
|
network.IsIPv4 = "yes"
|
|
network.IsIPv6 = "yes"
|
|
_, err := logic.GetNetwork("skynet6")
|
|
if err != nil {
|
|
logic.CreateNetwork(network)
|
|
}
|
|
}
|
|
|
|
func createNetHost() {
|
|
k, _ := wgtypes.ParseKey("DM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=")
|
|
netHost = models.Host{
|
|
ID: uuid.New(),
|
|
PublicKey: k.PublicKey(),
|
|
HostPass: "password",
|
|
OS: "linux",
|
|
Name: "nethost",
|
|
}
|
|
_ = logic.CreateHost(&netHost)
|
|
}
|