knadh/listmonk
1
1
Fork 0
mirror of https://github.com/knadh/listmonk.git synced 2025-03-01 00:35:28 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug in OIDC cookie check.

Browse source
This commit is contained in:
Kailash Nadh 2024-04-02 14:50:45 +05:30
parent 83e4f5def4
commit 4648f9122d
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
internal/oidc/oidc.go
View file

@ -88,7 +88,7 @@ func (o *OIDC) HandleCallback(c echo.Context) error {
Path: "/",
})
return c.Redirect(302, c.Request().URL.Query().Get("state"))
return c.Redirect(http.StatusTemporaryRedirect, c.Request().URL.Query().Get("state"))
}
func (o *OIDC) Middleware(next echo.HandlerFunc) echo.HandlerFunc {
@ -98,14 +98,14 @@ func (o *OIDC) Middleware(next echo.HandlerFunc) echo.HandlerFunc {
}
rawIDTk, err := c.Cookie("id_token")
if err != http.ErrNoCookie {
return echo.NewHTTPError(http.StatusInternalServerError, err.Error())
}
// Verify the token.
_, err = o.verifier.Verify(c.Request().Context(), rawIDTk.Value)
if err == nil {
return next(c)
// Verify the token.
_, err = o.verifier.Verify(c.Request().Context(), rawIDTk.Value)
if err == nil {
return next(c)
}
} else if err != http.ErrNoCookie {
return echo.NewHTTPError(http.StatusInternalServerError, err.Error())
}
// If the verification failed, redirect to the provider for auth.
@ -120,7 +120,7 @@ func (o *OIDC) Middleware(next echo.HandlerFunc) echo.HandlerFunc {
SameSite: http.SameSiteStrictMode,
Path: "/",
})
return c.Redirect(302, o.cfg.AuthCodeURL(c.Request().URL.RequestURI(), oidc.Nonce(nonce)))
return c.Redirect(http.StatusTemporaryRedirect, o.cfg.AuthCodeURL(c.Request().URL.RequestURI(), oidc.Nonce(nonce)))
}
}