From 7b9ba2efbccb60275dbe5bddca4162f5befa7cc8 Mon Sep 17 00:00:00 2001 From: SweetPPro Date: Tue, 9 Nov 2021 19:56:34 +0100 Subject: [PATCH] improved mobile navbar/sidebar (#574) * improved mobile navbar/sidebar Sidebar is hidden and all menu items moved to hamburger menu on mobile devices * improvements to menu rendering -removed redundant code -fixed an issue with emitting data to App.vue * Update Navigation.vue fixed linting errors * Add minor refactors to the mobile menu PR. - Fix indentation and line lengths. - Simplify prop definitions in the Navigation component. - Remove redundant computed methods and use prop variables directly in the Navigation compontent. - Simplify menu rendering logic by: removing isSidebar, showLogout and using simpler v-if / else in the parent instead of the Navigation component. * Update App.vue removed orphaned isSideBar Boolean Co-authored-by: Kailash Nadh --- frontend/fontello/config.json | 42 +++++--- frontend/src/App.vue | 118 +++++------------------ frontend/src/assets/icons/fontello.css | 1 + frontend/src/assets/icons/fontello.woff2 | Bin 7484 -> 7552 bytes frontend/src/components/Navigation.vue | 117 ++++++++++++++++++++++ 5 files changed, 170 insertions(+), 108 deletions(-) mode change 100644 => 100755 frontend/fontello/config.json mode change 100644 => 100755 frontend/src/assets/icons/fontello.woff2 create mode 100644 frontend/src/components/Navigation.vue diff --git a/frontend/fontello/config.json b/frontend/fontello/config.json old mode 100644 new mode 100755 index bf748a3b..d3ea0a2c --- a/frontend/fontello/config.json +++ b/frontend/fontello/config.json @@ -552,6 +552,20 @@ "speedometer" ] }, + { + "uid": "86efd4d8903ab613b84953efcef01406", + "css": "logout-variant", + "code": 984573, + "src": "custom_icons", + "selected": true, + "svg": { + "path": "M585.9 650.4L695.3 541H291V459H695.3L585.9 349.6 646.5 291 853.5 500 646.5 709ZM791 125Q826.2 125 850.6 149.4T875 209V402.3L791 320.3V209H209V791H791V679.7L875 597.7V791Q875 826.2 850.6 850.6T791 875H209Q173.8 875 149.4 850.6T125 791V209Q125 173.8 149.4 149.4T209 125H791Z", + "width": 1000 + }, + "search": [ + "logout-variant" + ] + }, { "uid": "f4ad3f6d071a0bfb3a8452b514ed0892", "css": "vector-square", @@ -21790,20 +21804,6 @@ "lock-plus" ] }, - { - "uid": "86efd4d8903ab613b84953efcef01406", - "css": "logout-variant", - "code": 984573, - "src": "custom_icons", - "selected": false, - "svg": { - "path": "M585.9 650.4L695.3 541H291V459H695.3L585.9 349.6 646.5 291 853.5 500 646.5 709ZM791 125Q826.2 125 850.6 149.4T875 209V402.3L791 320.3V209H209V791H791V679.7L875 597.7V791Q875 826.2 850.6 850.6T791 875H209Q173.8 875 149.4 850.6T125 791V209Q125 173.8 149.4 149.4T209 125H791Z", - "width": 1000 - }, - "search": [ - "logout-variant" - ] - }, { "uid": "90e8ca4d57b7f017c8a63b1dc2917046", "css": "music-note-bluetooth", @@ -74835,6 +74835,20 @@ "search": [ "set-split" ] + }, + { + "uid": "b39a043bdb10d9d11ccecca6f17a07fe", + "css": "logout-variant", + "code": 64737, + "src": "custom_icons", + "selected": false, + "svg": { + "path": "M586.7 649.6L694.6 541.7H291.7V458.3H694.6L586.7 350.4 645.8 291.7 854.2 500 645.8 708.3 586.7 649.6M791.7 125C837.5 125 875 162.5 875 208.3V402.9L791.7 319.6V208.3H208.3V791.7H791.7V680.4L875 597.1V791.7C875 837.5 837.5 875 791.7 875H208.3C162.1 875 125 837.5 125 791.7V208.3C125 162.1 162.1 125 208.3 125H791.7Z", + "width": 1000 + }, + "search": [ + "logout-variant" + ] } ] } \ No newline at end of file diff --git a/frontend/src/App.vue b/frontend/src/App.vue index ca2e24a2..d54c12e1 100644 --- a/frontend/src/App.vue +++ b/frontend/src/App.vue @@ -10,9 +10,11 @@ @@ -20,88 +22,15 @@