From f04798a3299b9644479a3bbb546efe68717dd782 Mon Sep 17 00:00:00 2001
From: Kailash Nadh <kailash@nadh.in>
Date: Mon, 25 Mar 2024 11:06:40 +0530
Subject: [PATCH] Add URL validation to settings URL inputs on admin UI.

---
 frontend/src/views/settings/general.vue    | 7 ++++---
 frontend/src/views/settings/media.vue      | 6 +++---
 frontend/src/views/settings/messengers.vue | 2 +-
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/frontend/src/views/settings/general.vue b/frontend/src/views/settings/general.vue
index df8d78fd..5bd15dd2 100644
--- a/frontend/src/views/settings/general.vue
+++ b/frontend/src/views/settings/general.vue
@@ -8,7 +8,7 @@
     <b-field :label="$t('settings.general.rootURL')" label-position="on-border"
       :message="$t('settings.general.rootURLHelp')">
       <b-input v-model="data['app.root_url']" name="app.root_url" placeholder="https://listmonk.yoursite.com"
-        :maxlength="300" required />
+        :maxlength="300" required type="url" pattern="https?://.*" />
     </b-field>
 
     <div class="columns">
@@ -16,14 +16,15 @@
         <b-field :label="$t('settings.general.logoURL')" label-position="on-border"
           :message="$t('settings.general.logoURLHelp')">
           <b-input v-model="data['app.logo_url']" name="app.logo_url" placeholder="https://listmonk.yoursite.com/logo.png"
-            :maxlength="300" />
+            :maxlength="300" type="url" pattern="https?://.*" />
         </b-field>
       </div>
       <div class="column is-6">
         <b-field :label="$t('settings.general.faviconURL')" label-position="on-border"
           :message="$t('settings.general.faviconURLHelp')">
           <b-input v-model="data['app.favicon_url']" name="app.favicon_url"
-            placeholder="https://listmonk.yoursite.com/favicon.png" :maxlength="300" />
+            placeholder="https://listmonk.yoursite.com/favicon.png" :maxlength="300"
+            type="url" pattern="https?://.*" />
         </b-field>
       </div>
     </div>
diff --git a/frontend/src/views/settings/media.vue b/frontend/src/views/settings/media.vue
index 0c248e60..8fd11008 100644
--- a/frontend/src/views/settings/media.vue
+++ b/frontend/src/views/settings/media.vue
@@ -97,14 +97,14 @@
         </div>
         <div class="column is-9">
           <b-field :label="$t('settings.media.s3.url')" label-position="on-border"
-            :message="$t('settings.media.s3.urlHelp')" expanded>
+            :message="$t('settings.media.s3.urlHelp')">
             <b-input v-model="data['upload.s3.url']" name="upload.s3.url" :disabled="!data['upload.s3.bucket']" required
-              placeholder="https://s3.$region.amazonaws.com" :maxlength="200" />
+              placeholder="https://s3.$region.amazonaws.com" :maxlength="200" expanded type="url" pattern="https?://.*" />
           </b-field>
           <b-field :label="$t('settings.media.s3.publicURL')" label-position="on-border" expanded>
             <b-input v-model="data['upload.s3.public_url']" :message="$t('settings.media.s3.publicURLHelp')"
               name="upload.s3.public_url" :disabled="!data['upload.s3.bucket']" placeholder="https://files.yourdomain.com"
-              :maxlength="200" />
+              :maxlength="200" type="url" pattern="https?://.*" />
           </b-field>
         </div>
       </div>
diff --git a/frontend/src/views/settings/messengers.vue b/frontend/src/views/settings/messengers.vue
index fd87596c..d09c123c 100644
--- a/frontend/src/views/settings/messengers.vue
+++ b/frontend/src/views/settings/messengers.vue
@@ -27,7 +27,7 @@
                 <b-field :label="$t('settings.messengers.url')" label-position="on-border"
                   :message="$t('settings.messengers.urlHelp')">
                   <b-input v-model="item.root_url" name="root_url" placeholder="https://postback.messenger.net/path"
-                    :maxlength="200" />
+                    :maxlength="200" expanded type="url" pattern="https?://.*" />
                 </b-field>
               </div>
             </div><!-- host -->