From 026af473ec23d465c68761b0904ec90db0aedd50 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonatan=20K=C5=82osko?= <jonatanklosko@gmail.com>
Date: Thu, 25 Jan 2024 17:55:52 +0800
Subject: [PATCH] Simplify terminal text clipboard icon

---
 assets/css/js_interop.css                               | 4 ----
 lib/livebook_web/live/hub/new_live.ex                   | 1 -
 lib/livebook_web/live/output.ex                         | 1 -
 lib/livebook_web/live/output/terminal_text_component.ex | 5 ++---
 4 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/assets/css/js_interop.css b/assets/css/js_interop.css
index f0494ef33..b507e850f 100644
--- a/assets/css/js_interop.css
+++ b/assets/css/js_interop.css
@@ -294,10 +294,6 @@ solely client-side operations.
   @apply hidden;
 }
 
-[phx-hook="VirtualizedLines"]:not(:hover) [data-el-clipcopy] {
-  @apply hidden;
-}
-
 /* === Session views === */
 
 [data-el-session][data-js-view="code-zen"] [data-el-view-toggle="code-zen"] {
diff --git a/lib/livebook_web/live/hub/new_live.ex b/lib/livebook_web/live/hub/new_live.ex
index 756d8e525..4974d4b94 100644
--- a/lib/livebook_web/live/hub/new_live.ex
+++ b/lib/livebook_web/live/hub/new_live.ex
@@ -167,7 +167,6 @@ defmodule LivebookWeb.Hub.NewLive do
 
       <button
         class="icon-button ml-4"
-        data-el-clipcopy
         phx-click={JS.dispatch("lb:clipcopy", to: "#clipboard-code")}
         type="button"
       >
diff --git a/lib/livebook_web/live/output.ex b/lib/livebook_web/live/output.ex
index 97fd8d84e..f83e495bd 100644
--- a/lib/livebook_web/live/output.ex
+++ b/lib/livebook_web/live/output.ex
@@ -393,7 +393,6 @@ defmodule LivebookWeb.Output do
       <div class="absolute right-2 top-0 z-10 invisible group-hover/error:visible">
         <button
           class="icon-button bg-gray-100"
-          data-el-clipcopy
           phx-click={JS.dispatch("lb:clipcopy", to: "##{@id}-message")}
         >
           <.remix_icon icon="clipboard-line" class="text-lg" />
diff --git a/lib/livebook_web/live/output/terminal_text_component.ex b/lib/livebook_web/live/output/terminal_text_component.ex
index 28c9f5cf4..0f7852602 100644
--- a/lib/livebook_web/live/output/terminal_text_component.ex
+++ b/lib/livebook_web/live/output/terminal_text_component.ex
@@ -51,7 +51,7 @@ defmodule LivebookWeb.Output.TerminalTextComponent do
     ~H"""
     <div
       id={@id}
-      class="relative"
+      class="relative group/root"
       phx-hook="VirtualizedLines"
       data-p-max-height={hook_prop(300)}
       data-p-follow={hook_prop(true)}
@@ -74,10 +74,9 @@ defmodule LivebookWeb.Output.TerminalTextComponent do
         phx-update="ignore"
       >
       </div>
-      <div class="absolute right-2 top-0 z-10">
+      <div class="absolute right-2 top-0 z-10 invisible group-hover/root:visible">
         <button
           class="icon-button bg-gray-100"
-          data-el-clipcopy
           phx-click={JS.dispatch("lb:clipcopy", to: "##{@id}-template")}
         >
           <.remix_icon icon="clipboard-line" class="text-lg" />