livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-12-17 21:50:25 +08:00
Code Issues Projects Releases Packages Wiki Activity

Do not close package search modal after adding the package (#2399)

Browse source 
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
This commit is contained in:
Sasikumar 2023-12-15 12:15:26 +05:30 • committed by GitHub
parent a8a963f2aa
commit 0711040d67
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/livebook_web/live/session_live.ex
View file

@ -627,8 +627,7 @@ defmodule LivebookWeb.SessionLive do
id: "package-search", id: "package-search",
session: %{ session: %{
"session_pid" => @session.pid, "session_pid" => @session.pid,
"runtime" => @data_view.runtime, "runtime" => @data_view.runtime
"return_to" => @self_path
} }
) %> ) %>
</.modal> </.modal>

9
lib/livebook_web/live/session_live/package_search_live.ex
View file

@ -2,16 +2,11 @@ defmodule LivebookWeb.SessionLive.PackageSearchLive do
use LivebookWeb, :live_view use LivebookWeb, :live_view
@impl true @impl true
def mount( def mount(_params, %{"session_pid" => session_pid, "runtime" => runtime}, socket) do
_params,
%{"session_pid" => session_pid, "runtime" => runtime, "return_to" => return_to},
socket
) do
socket = socket =
assign(socket, assign(socket,
session: Livebook.Session.get_by_pid(session_pid), session: Livebook.Session.get_by_pid(session_pid),
runtime: runtime, runtime: runtime,
return_to: return_to,
search: "", search: "",
search_ref: nil, search_ref: nil,
packages: [], packages: [],
@ -145,6 +140,6 @@ defmodule LivebookWeb.SessionLive.PackageSearchLive do
defp add_dependency(socket, dependency) do defp add_dependency(socket, dependency) do
Livebook.Session.add_dependencies(socket.assigns.session.pid, [dependency]) Livebook.Session.add_dependencies(socket.assigns.session.pid, [dependency])
push_patch(socket, to: socket.assigns.return_to) assign(socket, search: "", search_ref: nil, packages: [])
end end
end end