Improve ZTA experience

This commit is contained in:
José Valim 2024-05-09 21:31:47 +02:00
parent 8d15d5e93c
commit 096ac829e8
2 changed files with 15 additions and 7 deletions

View file

@ -21,8 +21,15 @@ defmodule Livebook.Teams.DeploymentGroup do
end
def changeset(deployment_group, attrs \\ %{}) do
deployment_group
|> cast(attrs, [:id, :name, :mode, :hub_id, :clustering, :zta_provider, :zta_key])
|> validate_required([:name, :mode])
changeset =
deployment_group
|> cast(attrs, [:id, :name, :mode, :hub_id, :clustering, :zta_provider, :zta_key])
|> validate_required([:name, :mode])
if get_field(changeset, :zta_provider) do
validate_required(changeset, [:zta_key])
else
changeset
end
end
end

View file

@ -91,7 +91,7 @@ defmodule LivebookWeb.AppComponents do
def deployment_group_form_content(assigns) do
~H"""
<div class="grid grid-cols-1 md:grid-cols-2 gap-3">
<div>
<div class="flex flex-col">
<.select_field
label="Clustering"
@ -137,9 +137,10 @@ defmodule LivebookWeb.AppComponents do
field={@form[:zta_provider]}
help={
~S'''
Enable this option if you want
to deploy your notebooks behind
an authentication proxy
Enable this option to generate
Livebook Dockerfiles with proxy
authentication for deployed
notebooks
'''
}
prompt="None"