From 1f496c86052711a486bb8c26c09d406d64aa04fb Mon Sep 17 00:00:00 2001 From: Wojtek Mach Date: Tue, 28 Feb 2023 13:53:18 +0100 Subject: [PATCH] Typing env and secret name automatically upcases (#1736) --- lib/livebook_web/components/form_components.ex | 3 ++- lib/livebook_web/live/env_var_component.ex | 1 + lib/livebook_web/live/session_live/secrets_component.ex | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/livebook_web/components/form_components.ex b/lib/livebook_web/components/form_components.ex index abb7c6bdd..560809c72 100644 --- a/lib/livebook_web/components/form_components.ex +++ b/lib/livebook_web/components/form_components.ex @@ -14,6 +14,7 @@ defmodule LivebookWeb.FormComponents do attr :value, :any attr :errors, :list, default: [] attr :field, Phoenix.HTML.FormField, doc: "a form field struct retrieved from the form" + attr :class, :string, default: nil attr :rest, :global, include: ~w(autocomplete readonly disabled) @@ -27,7 +28,7 @@ defmodule LivebookWeb.FormComponents do name={@name} id={@id || @name} value={Phoenix.HTML.Form.normalize_value("text", @value)} - class="input" + class={["input", @class]} {@rest} /> diff --git a/lib/livebook_web/live/env_var_component.ex b/lib/livebook_web/live/env_var_component.ex index 9400413b4..df0bdf403 100644 --- a/lib/livebook_web/live/env_var_component.ex +++ b/lib/livebook_web/live/env_var_component.ex @@ -45,6 +45,7 @@ defmodule LivebookWeb.EnvVarComponent do field={f[:name]} label="Name (alphanumeric and underscore)" autofocus={@operation == :new} + class="uppercase" /> <.text_field field={f[:value]} label="Value" autofocus={@operation == :edit} /> <.hidden_field field={f[:operation]} value={@operation} /> diff --git a/lib/livebook_web/live/session_live/secrets_component.ex b/lib/livebook_web/live/session_live/secrets_component.ex index f814f2c6c..77216d055 100644 --- a/lib/livebook_web/live/session_live/secrets_component.ex +++ b/lib/livebook_web/live/session_live/secrets_component.ex @@ -98,6 +98,7 @@ defmodule LivebookWeb.SessionLive.SecretsComponent do spellcheck="false" autocomplete="off" phx-debounce="blur" + class="uppercase" /> <.text_field field={f[:value]}