livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-11-10 14:11:29 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix units in byte formatting (#1494)

Browse source
This commit is contained in:
Jonatan Kłosko 2022-10-20 11:56:10 +02:00 • committed by GitHub
parent 567b7af459
commit 23e071386b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
lib/livebook/utils.ex
View file

@ -463,8 +463,8 @@ defmodule Livebook.Utils do
iex> Livebook.Utils.format_bytes(0) iex> Livebook.Utils.format_bytes(0)
"0 B" "0 B"
iex> Livebook.Utils.format_bytes(1000) iex> Livebook.Utils.format_bytes(900)
"1000 B" "900 B"
iex> Livebook.Utils.format_bytes(1100) iex> Livebook.Utils.format_bytes(1100)
"1.1 KB" "1.1 KB"
@ -473,11 +473,13 @@ defmodule Livebook.Utils do
"1.2 MB" "1.2 MB"
iex> Livebook.Utils.format_bytes(1_363_148_800) iex> Livebook.Utils.format_bytes(1_363_148_800)
"1.3 GB" "1.4 GB"
iex> Livebook.Utils.format_bytes(1_503_238_553_600) iex> Livebook.Utils.format_bytes(1_503_238_553_600)
"1.4 TB" "1.5 TB"
""" """
@spec format_bytes(non_neg_integer()) :: String.t()
def format_bytes(bytes) when is_integer(bytes) do def format_bytes(bytes) when is_integer(bytes) do
cond do cond do
bytes >= memory_unit(:TB) -> format_bytes(bytes, :TB) bytes >= memory_unit(:TB) -> format_bytes(bytes, :TB)
@ -495,10 +497,10 @@ defmodule Livebook.Utils do
"#{:erlang.float_to_binary(value, decimals: 1)} #{unit}" "#{:erlang.float_to_binary(value, decimals: 1)} #{unit}"
end end
defp memory_unit(:TB), do: 1024 * 1024 * 1024 * 1024 defp memory_unit(:TB), do: 1_000_000_000_000
defp memory_unit(:GB), do: 1024 * 1024 * 1024 defp memory_unit(:GB), do: 1_000_000_000
defp memory_unit(:MB), do: 1024 * 1024 defp memory_unit(:MB), do: 1_000_000
defp memory_unit(:KB), do: 1024 defp memory_unit(:KB), do: 1_000
@doc """ @doc """
Gets the port for an existing listener. Gets the port for an existing listener.