livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-08 12:36:36 +08:00
Code Issues Projects Releases Packages Wiki Activity

Make app new session button a link

Browse source
This commit is contained in:
Jonatan Kłosko 2023-07-11 13:57:50 +02:00
parent cc24a8b73c
commit 29122ccf5e
3 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/livebook_web/live/app_live.ex
View file

@ -62,10 +62,10 @@ defmodule LivebookWeb.AppLive do
<% end %> <% end %>
</p> </p>
<div class="flex justify-end"> <div class="flex justify-end">
<button class="button-base button-outlined-blue" phx-click="new_session"> <.link class="button-base button-outlined-blue" patch={~p"/apps/#{@app.slug}/new"}>
<.remix_icon icon="add-line" class="align-middle mr-1" /> <.remix_icon icon="add-line" class="align-middle mr-1" />
<span>New session</span> <span>New session</span>
</button> </.link>
</div> </div>
<div :if={@app_settings.show_existing_sessions} class="w-full flex flex-col space-y-4"> <div :if={@app_settings.show_existing_sessions} class="w-full flex flex-col space-y-4">
<.link <.link
@ -94,13 +94,15 @@ defmodule LivebookWeb.AppLive do
def render(assigns), do: auth_placeholder(assigns) def render(assigns), do: auth_placeholder(assigns)
@impl true @impl true
def handle_event("new_session", %{}, socket) do def handle_params(_params, _url, socket) when socket.assigns.live_action == :new_session do
session_id = session_id =
Livebook.App.get_session_id(socket.assigns.app.pid, user: socket.assigns.current_user) Livebook.App.get_session_id(socket.assigns.app.pid, user: socket.assigns.current_user)
{:noreply, push_navigate(socket, to: ~p"/apps/#{socket.assigns.app.slug}/#{session_id}")} {:noreply, push_navigate(socket, to: ~p"/apps/#{socket.assigns.app.slug}/#{session_id}")}
end end
def handle_params(_params, _url, socket), do: {:noreply, socket}
@impl true @impl true
def handle_info({:app_updated, app}, socket) do def handle_info({:app_updated, app}, socket) do
{:noreply, assign(socket, :app, app)} {:noreply, assign(socket, :app, app)}

1
lib/livebook_web/router.ex
View file

@ -113,6 +113,7 @@ defmodule LivebookWeb.Router do
pipe_through [:browser, :user] pipe_through [:browser, :user]
live "/apps/:slug", AppLive, :page live "/apps/:slug", AppLive, :page
live "/apps/:slug/new", AppLive, :new_session
live "/apps/:slug/authenticate", AppAuthLive, :page live "/apps/:slug/authenticate", AppAuthLive, :page
live "/apps/:slug/:id", AppSessionLive, :page live "/apps/:slug/:id", AppSessionLive, :page

2
test/livebook_web/live/app_live_test.exs
View file

@ -84,7 +84,7 @@ defmodule LivebookWeb.AppLiveTest do
{:error, {:live_redirect, %{to: to}}} = {:error, {:live_redirect, %{to: to}}} =
view view
|> element("button", "New session") |> element("a", "New session")
|> render_click() |> render_click()
assert_receive {:app_updated, %{pid: ^app_pid, sessions: [%{id: session_id}]}} assert_receive {:app_updated, %{pid: ^app_pid, sessions: [%{id: session_id}]}}