Remove refute_receive

Whenever possible, we use refute_received instead.
Others were fully removed, because we were matching
events from other tests.

test/livebook/runtime/evaluator/object_tracker_test.exs

@@ -24,7 +24,7 @@ defmodule Livebook.Runtime.Evaluator.ObjectTrackerTest do
     ObjectTracker.remove_reference_sync(object_tracker, {self(), :ref1})
     ObjectTracker.remove_reference_sync(object_tracker, {self(), :ref2})
 
-    assert_receive :object1_released
+    assert_received :object1_released
   end
 
   test "does not execute hooks when other references still point to the object",
@@ -36,7 +36,7 @@ defmodule Livebook.Runtime.Evaluator.ObjectTrackerTest do
 
     ObjectTracker.remove_reference_sync(object_tracker, {self(), :ref1})
 
-    refute_receive :object1_released
+    refute_received :object1_released
   end
 
   test "remove_reference_sync/2 awaits for monitor acknowledgements",

test/livebook_teams/hubs/team_client_test.exs

@@ -85,7 +85,7 @@ defmodule Livebook.Hubs.TeamClientTest do
       # creates the secret
       user_connected = %{user_connected | secrets: [livebook_proto_secret]}
       pid = connect_to_teams(team)
-      refute_receive {:secret_created, ^secret}
+      refute_received {:secret_created, ^secret}
       send(pid, {:event, :user_connected, user_connected})
       assert_receive {:secret_created, ^secret}
       assert secret in TeamClient.get_secrets(team.id)
@@ -134,7 +134,7 @@ defmodule Livebook.Hubs.TeamClientTest do
       # creates the file system
       user_connected = %{user_connected | file_systems: [livebook_proto_file_system]}
       pid = connect_to_teams(team)
-      refute_receive {:file_system_created, ^file_system}
+      refute_received {:file_system_created, ^file_system}
       send(pid, {:event, :user_connected, user_connected})
       assert_receive {:file_system_created, ^file_system}
       assert file_system in TeamClient.get_file_systems(team.id)
@@ -190,7 +190,7 @@ defmodule Livebook.Hubs.TeamClientTest do
       # creates the deployment group
       user_connected = %{user_connected | deployment_groups: [livebook_proto_deployment_group]}
       pid = connect_to_teams(team)
-      refute_receive {:deployment_group_created, ^deployment_group}
+      refute_received {:deployment_group_created, ^deployment_group}
       send(pid, {:event, :user_connected, user_connected})
       assert_receive {:deployment_group_created, ^deployment_group}
       assert deployment_group in TeamClient.get_deployment_groups(team.id)
@@ -349,7 +349,7 @@ defmodule Livebook.Hubs.TeamClientTest do
       # creates the secret
       agent_connected = %{agent_connected | secrets: [livebook_proto_secret]}
       pid = connect_to_teams(team)
-      refute_receive {:secret_created, ^secret}
+      refute_received {:secret_created, ^secret}
       send(pid, {:event, :agent_connected, agent_connected})
       assert_receive {:secret_created, ^secret}
       assert secret in TeamClient.get_secrets(team.id)
@@ -398,7 +398,7 @@ defmodule Livebook.Hubs.TeamClientTest do
       # creates the file system
       agent_connected = %{agent_connected | file_systems: [livebook_proto_file_system]}
       pid = connect_to_teams(team)
-      refute_receive {:file_system_created, ^file_system}
+      refute_received {:file_system_created, ^file_system}
       send(pid, {:event, :agent_connected, agent_connected})
       assert_receive {:file_system_created, ^file_system}
       assert file_system in TeamClient.get_file_systems(team.id)
@@ -526,7 +526,7 @@ defmodule Livebook.Hubs.TeamClientTest do
       # creates the secret
       agent_connected = %{agent_connected | secrets: [livebook_proto_secret]}
       pid = connect_to_teams(team)
-      refute_receive {:secret_created, ^secret}
+      refute_received {:secret_created, ^secret}
       send(pid, {:event, :agent_connected, agent_connected})
       assert_receive {:secret_created, ^secret}
       assert secret in TeamClient.get_secrets(team.id)

test/livebook_teams/hubs_test.exs

@@ -142,8 +142,6 @@ defmodule Livebook.HubsTest do
     assert Hubs.delete_secret(hub, secret) ==
              {:transport_error,
               "Something went wrong, try again later or please file a bug if it persists"}
-
-    refute_receive {:secret_deleted, _}
   end
 
   describe "create_file_system/2" do
@@ -168,7 +166,6 @@ defmodule Livebook.HubsTest do
 
       assert {:error, changeset} = Hubs.create_file_system(hub, file_system)
       assert "can't be blank" in errors_on(changeset).bucket_url
-      refute_receive {:file_system_created, _}
     end
   end
 
@@ -204,7 +201,6 @@ defmodule Livebook.HubsTest do
 
       assert {:error, changeset} = Hubs.update_file_system(hub, update_file_system)
       assert "can't be blank" in errors_on(changeset).bucket_url
-      refute_receive {:file_system_updated, _}
     end
   end
 
@@ -225,8 +221,6 @@ defmodule Livebook.HubsTest do
     assert Hubs.delete_file_system(hub, file_system) ==
              {:transport_error,
               "Something went wrong, try again later or please file a bug if it persists"}
-
-    refute_receive {:file_system_deleted, _}
   end
 
   test "generates and verifies stamp for a notebook", %{user: user, node: node} do

test/livebook_teams/teams_test.exs

@@ -191,7 +191,6 @@ defmodule Livebook.TeamsTest do
 
       assert {:error, changeset} = Teams.create_deployment_group(team, deployment_group)
       assert "can't be blank" in errors_on(changeset).name
-      refute_receive {:deployment_group_created, _}
     end
 
     test "returns changeset errors when the mode is invalid", %{user: user, node: node} do
@@ -200,7 +199,6 @@ defmodule Livebook.TeamsTest do
 
       assert {:error, changeset} = Teams.create_deployment_group(team, deployment_group)
       assert "is invalid" in errors_on(changeset).mode
-      refute_receive {:deployment_group_created, _}
     end
   end
 

test/livebook_teams/web/hub/edit_live_test.exs

@@ -330,7 +330,6 @@ defmodule LivebookWeb.Integration.Hub.EditLiveTest do
              |> render_submit(attrs) =~
                "You are not authorized to perform this action, make sure you have the access and you are not in a Livebook App Server/Offline instance"
 
-      refute_receive {:secret_created, ^secret}
       refute secret in Livebook.Hubs.get_secrets(hub)
     end
 
@@ -339,11 +338,9 @@ defmodule LivebookWeb.Integration.Hub.EditLiveTest do
 
       bypass = Bypass.open()
       file_system = build_bypass_file_system(bypass, hub.id)
-      id = file_system.id
       attrs = %{file_system: Livebook.FileSystem.dump(file_system)}
 
       expect_s3_listing(bypass)
-
       refute render(view) =~ file_system.bucket_url
 
       view
@@ -358,7 +355,6 @@ defmodule LivebookWeb.Integration.Hub.EditLiveTest do
              |> render_submit(attrs) =~
                "You are not authorized to perform this action, make sure you have the access and you are not in a Livebook App Server/Offline instance"
 
-      refute_receive {:file_system_created, %{id: ^id}}
       refute file_system in Livebook.Hubs.get_file_systems(hub)
     end
   end