livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2026-01-11 01:59:11 +08:00
Code Issues Projects Releases Packages Wiki Activity

Improve scroll on cell focus/blur (#659)

Browse source 
* Stay in insert mode only if evaluate is clicked

* Never scroll when focusing cell with click
This commit is contained in:
Jonatan Kłosko 2021-10-29 15:05:59 +02:00 • committed by GitHub
parent 4493a60380
commit 40158aa6cc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
assets/js/session/index.js
View file

@ -392,13 +392,14 @@ function handleDocumentMouseDown(hook, event) {
return;
}
// If click targets a clickable element that awaits mouse up, keep the focus as is
if (event.target.closest(`a, button`)) {
// If the pencil icon is clicked, enter insert mode
if (event.target.closest(`[data-element="enable-insert-mode-button"]`)) {
setInsertMode(hook, true);
}
// If the pencil icon is clicked, enter insert mode
if (event.target.closest(`[data-element="enable-insert-mode-button"]`)) {
setInsertMode(hook, true);
return;
}
// If primary cell action is clicked, keep the focus as is
if (event.target.closest(`[data-element="actions"][data-primary]`)) {
return;
}
@ -408,7 +409,7 @@ function handleDocumentMouseDown(hook, event) {
const insertMode = editableElementClicked(event, cell);
if (cellId !== hook.state.focusedCellId) {
setFocusedCell(hook, cellId, !insertMode);
setFocusedCell(hook, cellId, false);
}
// Depending on whether the click targets editor disable/enable insert mode